Remove unnecessary override of /etc/init.d/docker on containervm image. #23593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
|
GCE e2e build/test passed for commit c5ac60f. |
|
Change LGTM since the override was meant to be a temporary solution. However, I am not sure what the race was and how it caused the failure... |
yujuhong
added
the
lgtm
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
|
Every cherrypick needs a release note. |
bgrant0607
added
release-note
|
GCE e2e build/test passed for commit c5ac60f. |
|
Please create a cherrypick PR. |
bgrant0607
referenced
this pull request
Mar 31, 2016
…593-upstream-release-1.2 Remove unnecessary override of /etc/init.d/docker on containervm image.
|
Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
referenced
this pull request
in shyamjvs/kubernetes
Dec 1, 2016
…ick-of-#23593-upstream-release-1.2 Remove unnecessary override of /etc/init.d/docker on containervm image.
shouhong
referenced
this pull request
in shouhong/kubernetes
Feb 14, 2017
…ick-of-#23593-upstream-release-1.2 Remove unnecessary override of /etc/init.d/docker on containervm image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced by #20307 to change docker -d to docker daemon. It should be removed once we upgraded to the new containervm image, but obviously this one fall off the radar.
I believe this one is causing a rare race which makes two docker daemons running on the master node of GKE.
cc/ @cjcullen @jlowdermilk