mount instanceid file from config drive when using openstack cloud provider #23733
Conversation
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
k8s-github-robot
added
size/S
|
cc @ashw7n |
|
ok to test |
|
@davidopp is there any comments? :) |
|
I'm not qualified to review this. I was hoping @ashw7n would take a look |
|
LGTM |
davidopp
added
ok-to-merge
release-note-none
zhouhaibing089
force-pushed
the
instanceid-fix
branch
from
4f0fc52
to
7c48e1a
Compare
k8s-github-robot
removed
the
lgtm
zhouhaibing089
force-pushed
the
instanceid-fix
branch
from
7c48e1a
to
1285b3a
Compare
bprashanth
added
the
lgtm
zhouhaibing089
force-pushed
the
instanceid-fix
branch
from
1285b3a
to
cee09e1
Compare
|
@davidopp @bprashanth unit testing failed may caused by the long time since last change, just rebased the code. |
k8s-github-robot
removed
the
lgtm
madhusudancs
added
the
lgtm
|
@madhusudancs |
k8s-github-robot
removed
the
lgtm
madhusudancs
added
the
lgtm
|
@k8s-bot test this please, issue: #IGNORE (some Jenkins issues) |
wojtek-t
added
lgtm
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
4 similar comments
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
GCE e2e build/test passed for commit cee09e1. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit cee09e1. |
|
Automatic merge from submit-queue |
Bug 1744422: UPSTREAM: 82335: defer the close to after the error check Origin-commit: ea09adc44faa5bfd532afc199c804b542308c051
Bug 1744422: UPSTREAM: 82335: defer the close to after the error check Origin-commit: ea09adc44faa5bfd532afc199c804b542308c051
fix #23191, the instanceid file is read however we do not mount it as a volume, and it would cause the cloud provider contacts the metadata server, in some cases, the metadata server is not able to serve, then the cloud provider would fail to initialize, we should avoid that.
This change is