-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping up etcd dep to fix data race #23808
Conversation
Labelling this PR as size/XS |
GCE e2e build/test failed for commit 34908ac9b4145ab2992ef20d3794ca251c9396a4. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
GCE e2e build/test failed for commit eff39aa3cd8c60dd86850e965b91e431618cd7ef. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
GCE e2e build/test failed for commit 812e120a100c7f49cb7e479c43a9322825acbd38. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
It seemed like etcd master dropped support for go 1.4 |
I assigned the PR to you. You should 'unassign' the PR when you are ready. Or ping me/re-assign to me. |
Blocked on #22149 |
GCE e2e build/test passed for commit 1c11fc65e021c275e05c7aa7978c3e8e499ca1a9. |
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
GCE e2e build/test passed for commit f9af323. |
@hongchaodeng please squash commits. |
/cc @ixdy |
Should probably be explicitly noted somewhere that this PR ratchets us into Go 1.6+, assuming I'm understanding correctly. |
OK, though due to #20656 Kubernetes basically doesn't support go 1.5. |
My basic worry is thus: we just merged the Go 1.6 PR yesterday, and we've been seeing some failures in CI that we can't fully explain away yet. I'm hesitant to lock us into Go 1.5+ until we're sure that things are not broken and we're not going to roll back. cc @kubernetes/goog-testing |
Closing this to transfer discussion to #23915. Once go version is resolved, will open up another PR. |
@ixdy - one point from me about Go 1.6 to note - we don't observe any performance issues with it, so from performance perspective the upgrade is fine. |
all Google-run Jenkins VMs should be using Go 1.6 now. |
ref: #23694
What this PR does