-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trusty: Do not create the docker-daemon cgroup #23996
Conversation
Reviewers, I have run e2e for this change, and tests are all green Ran 163 of 274 Specs in 4494.018 seconds |
Labelling this PR as size/XS |
LGTM |
Removing label |
@dchen1107 I think we also need "release-note" label because I was told that every PR to be cherry picked needs such a label. The default release note for this PR is its title, which I think is accurate. |
Removing LGTM because the release note process has not been followed. |
There is no need to block current patch release: 1.2.2. We can include this one and a fix to test itself to next patch release. cc/ @roberthbailey @bgrant0607 |
@andyzheng0831 - looks like a test failed (likely flaky). Can you investigate and poke the bot? |
GCE e2e build/test passed for commit b1e18f3. |
The build failure: No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. I did some search and noticed that this happened before. @k8s-bot unit test this issue: #IGNORE |
LGTM |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit b1e18f3. |
Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
…ry-pick-of-#23996-upstream-release-1.2 Automatic merge from submit-queue Automated cherry pick of kubernetes#23996 Cherry pick of kubernetes#23996 on release-1.2.
…ry-pick-of-#23996-upstream-release-1.2 Automatic merge from submit-queue Automated cherry pick of kubernetes#23996 Cherry pick of kubernetes#23996 on release-1.2.
This is a part of fix for issue #23956. But only when #23961 is also fixed, the Jenkins testing on our image will be green.
@dchen1107 @vishh please review this. Please also add "release note" and "cherrypick-candidate" labels, and mark it as milestone 1.2, as we also need to add this correct logic in 1.2 releases.
cc/ @wonderfly @roberthbailey @fabioy FYI.