client-gen: use serializer instead of codec for versioned client #24395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caesarxuchao
added
the
sig/api-machinery
caesarxuchao
changed the title
k8s-github-robot
added
size/M
|
GCE e2e build/test passed for commit 7ce65c848a7a9ed4dc03eaeae0ed8e244f5a79d4. |
caesarxuchao
added
release-note-none
caesarxuchao
changed the title
| @@ -167,7 +176,7 @@ func New(c *$.RESTClient|raw$) *$.Group$Client { | |||
| return &$.Group$Client{c} | |||
| } | |||
| ` | |||
| var setClientDefaultsTemplate = ` | |||
| var legacySetClientDefaultsTemplate = ` | |||
There was a problem hiding this comment.
I don't think legacy is descriptive here-- maybe setClientInternalVersionDefaultsTemplate?
|
GCE e2e build/test passed for commit 6ccd82a2e2e8f7badef90526441977f39c62c6c3. |
caesarxuchao
force-pushed
the
use-serializer
branch
from
6ccd82a
to
32ce0e3
Compare
|
Comments addressed. PTAL. Thanks. |
| @@ -17,6 +17,7 @@ limitations under the License. | |||
| package v1beta1 | |||
|
|
|||
| import ( | |||
| fmt "fmt" | |||
There was a problem hiding this comment.
That's my import code-- it does that because it's too dumb to tell if the package name matches the path name. Could be fixed with a small amount of effort.
|
LGTM |
lavalamp
added
lgtm
|
Actually maybe you can squash & apply label yourself. Thanks. |
|
GCE e2e build/test passed for commit 32ce0e3092d4fec7e451640c8ffe7c6697a4c4a1. |
caesarxuchao
force-pushed
the
use-serializer
branch
from
32ce0e3
to
4b5ef39
Compare
caesarxuchao
added
the
lgtm
|
GCE e2e build/test passed for commit 4b5ef39. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a versioned client, because the output of every client method is a versioned object, so it should use a serializer instead of a codec that does conversion.
@lavalamp @krousey