Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gce.getDiskByNameUnknownZone logic. #24452

Merged
merged 1 commit into from
Apr 19, 2016
Merged

Fix gce.getDiskByNameUnknownZone logic. #24452

merged 1 commit into from
Apr 19, 2016

Conversation

a-robinson
Copy link
Contributor

@a-robinson a-robinson commented Apr 19, 2016 •
edited
Loading

Fixes #24447.

Release note: Fixed bug (#24447) that kept GCE disks from being labeled with the correct zone or deleted in multi-zone (Ubernetes Lite) clusters.

@saad-ali @quinton-hoole

@a-robinson a-robinson added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 19, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2016
@a-robinson a-robinson added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 19, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

GCE e2e build/test passed for commit d69ccd5.

@roberthbailey roberthbailey added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 19, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@roberthbailey
Copy link
Contributor

Please create a cherry pick pull for this PR once it has merged into the master branch (and we've verified that it fixes the tests).

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

GCE e2e build/test passed for commit d69ccd5.

@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

GCE e2e build/test passed for commit d69ccd5.

@a-robinson a-robinson added this to the v1.2 milestone Apr 19, 2016
@a-robinson
Copy link
Contributor Author

@k8s-bot please node e2e test this issue: #24479

@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

GCE e2e build/test passed for commit d69ccd5.

@a-robinson
Copy link
Contributor Author

@k8s-oncall, any concerns about merging manually to fix a broken e2e and get it into the 1.2 release branch sooner?

@a-robinson
Copy link
Contributor Author

Ah, probably not necessary, looks like the P0 priority is helping with its submit-queue position now that it's showing up there.

@ghost ghost removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2016
@ghost
Copy link

ghost commented Apr 19, 2016

Removed LGTM. I'd like to consider amendments to the PR. Details shortly.

@ghost
Copy link

ghost commented Apr 19, 2016

Never mind - I was confused. This looks perfect. Apologies for any delay caused. I'd be happy to merge this manually, if @k8s-oncall is comfortable with that.

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 19, 2016

GCE e2e build/test passed for commit d69ccd5.

@a-robinson a-robinson merged commit 23a8401 into kubernetes:master Apr 19, 2016
a-robinson added a commit that referenced this pull request Apr 19, 2016
@a-robinson
Merge pull request #24491 from a-robinson/automated-cherry-pick-of-#2…
f2d4b68 
…4452-upstream-release-1.2

Automated cherry pick of #24452 upstream release 1.2
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@a-robinson
Merge pull request kubernetes#24491 from a-robinson/automated-cherry-…
aa824cb 
…pick-of-#24452-upstream-release-1.2

Automated cherry pick of kubernetes#24452 upstream release 1.2
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@a-robinson
Merge pull request kubernetes#24491 from a-robinson/automated-cherry-…
8a65521 
…pick-of-#24452-upstream-release-1.2

Automated cherry pick of kubernetes#24452 upstream release 1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@a-robinson @k8s-bot @k8s-cherrypick-bot @roberthbailey @k8s-teamcity-mesosphere @googlebot @saad-ali @k8s-github-robot