Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for running clusters on GCI #24893

Merged
merged 1 commit into from
Apr 28, 2016
Merged

Add support for running clusters on GCI #24893

merged 1 commit into from
Apr 28, 2016

Conversation

andyzheng0831
Copy link

@andyzheng0831 andyzheng0831 commented Apr 27, 2016 •
edited
Loading

Google Container-VM Image (GCI) is the next revision of Container-VM. See documentation at https://cloud.google.com/compute/docs/containers/vm-image/. This change adds support for starting a Kubernetes cluster using GCI.

With this change, users can start a kubernetes cluster using the latest kubelet and kubectl release binary built in the GCI image by running:

$ KUBE_OS_DISTRIBUTION="gci" cluster/kube-up.sh

Or run a testing cluster on GCI by running:

$ KUBE_OS_DISTRIBUTION="gci" go run hack/e2e.go -v --up

The commands above will choose the latest GCI image by default.

@andyzheng0831
Copy link
Author

andyzheng0831 commented Apr 27, 2016 •
edited
Loading

@dchen1107 @roberthbailey please review this change, and mark it as a cherry-pick candidate for release-1.2

cc/ @fabioy @wonderfly @zmerlynn @maisem @yinghan @adityakali @Amey-D @aulanov @SaiedKazemi, who have been making great contribution to GCI.

@dchen1107 dchen1107 self-assigned this Apr 27, 2016
@dchen1107
Copy link
Member

Are we still calling this image as GCI image?

@andyzheng0831
Copy link
Author

The full name is "Google ContainerVM Image", which is different from the previous name. But it is still short for "GCI"

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 27, 2016
@SaiedKazemi
Copy link

@andyzheng0831 Great job Andy!

@dchen1107
Copy link
Member

LGTM

@dchen1107 dchen1107 added lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 27, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2016
@dchen1107 dchen1107 added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Apr 27, 2016
@zmerlynn zmerlynn added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 28, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@zmerlynn zmerlynn added this to the v1.2 milestone Apr 28, 2016
@andyzheng0831
Copy link
Author

@k8s-bot test this issue #24422

@k8s-bot
Copy link

k8s-bot commented Apr 28, 2016

GCE e2e build/test passed for commit 93929c3.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Apr 28, 2016

GCE e2e build/test passed for commit 93929c3.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 19408e5 into kubernetes:master Apr 28, 2016
@andyzheng0831 andyzheng0831 mentioned this pull request Apr 28, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 28, 2016
Merge pull request #24936 from andyzheng0831/automated-cherry-pick-of…
8c703e1 
…-#24893-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of #24893

Cherry pick of #24893 on release-1.2.
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@andyzheng0831 andyzheng0831 deleted the gci branch April 29, 2016 16:32
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#24936 from andyzheng0831/automated-cher…
85ed5c2 
…ry-pick-of-#24893-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of kubernetes#24893

Cherry pick of kubernetes#24893 on release-1.2.
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
Merge pull request kubernetes#24936 from andyzheng0831/automated-cher…
9a1063e 
…ry-pick-of-#24893-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of kubernetes#24893

Cherry pick of kubernetes#24893 on release-1.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@andyzheng0831 @dchen1107 @SaiedKazemi @k8s-cherrypick-bot @k8s-bot @k8s-github-robot @zmerlynn @googlebot