Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #24937: flake pod not found #25121

Merged
merged 1 commit into from
May 6, 2016
Merged

fix #24937: flake pod not found #25121

merged 1 commit into from
May 6, 2016

Conversation

liangchenye
Copy link
Contributor

#24937
Split from #24191
Signed-off-by: liang chenye liangchenye@huawei.com

@liangchenye
Copy link
Contributor Author

@k8s-bot test this issue #23974

@liangchenye
Copy link
Contributor Author

@Random-Liu @pwittrock PTAL

@Random-Liu Random-Liu assigned Random-Liu and unassigned ixdy May 4, 2016
@Random-Liu
Copy link
Member

@liangchenye This one may not work as what you expected. Once the test fails before Delete the pod, the pod will left there and no one would ever delete it, so we should still delete pod in AfterEach.

BTW, what do you mean by:

So, I guess it should be something like this: in the 'Delete' test, it creates a pod at B point
and delete the pod at D point. I made a test, if it creates a pod at A point, there will be a creation error.

Do you mean that after successfully delete a pod, you can not create it immediately?

Moreover, FYI, #24445 has been merged. We can start using the framework in our future PRs.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2016
Signed-off-by: liang chenye <liangchenye@huawei.com>
@liangchenye
Copy link
Contributor Author

@Random-Liu use UUID

@Random-Liu Random-Liu added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-merge labels May 5, 2016
@Random-Liu
Copy link
Member

Mark P1 to get rid of the flake.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2016
@Random-Liu Random-Liu added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 5, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 6, 2016

GCE e2e build/test passed for commit 3c9306e.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2ebd771 into kubernetes:master May 6, 2016
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Jun 19, 2020
Bug 1847185: fix: GetLabelsForVolume panic issue for azure disk PV

Origin-commit: a4ab462c58dd5fd0ab4408ea8bfe5dfebaaa17ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants