Delete pod with uid as precondition. #25224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
added
kind/bug
caesarxuchao
added
the
lgtm
|
LGTM. Thanks. |
k8s-github-robot
added
size/XS
Random-Liu
added
release-note-none
| if err := m.kubeClient.Core().Pods(pod.Namespace).Delete(pod.Name, api.NewDeleteOptions(0)); err == nil { | ||
| // The delete options guaranteed that: | ||
| // 1. The pod should be deleted immediately | ||
| // 2. Only the pod with the same uid should be deleted. See #25169 |
There was a problem hiding this comment.
This is obviously the right thing to do. Don't think we need to link the issue :-)
maybe change the comment to "Use the pod UID as the precondition for deletion to prevent deleting a newly created pod with the same name and namespace"
Random-Liu
force-pushed
the
delete-pod-with-uid
branch
from
64f439f
to
cb6fe9e
Compare
Random-Liu
removed
the
lgtm
|
@yujuhong Addressed comments. |
Random-Liu
added
the
lgtm
|
LGTM. Thanks! |
Random-Liu
added
the
priority/important-soon
|
Mark P1 to get rid of flakes. |
|
GCE e2e build/test passed for commit cb6fe9e. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed #25169 (comment).
Fix #25169
Fix #24937
This PR change status manager to delete pods with uid as a precondition, so that kubelet won't delete pods with different uid but the same name and namespace accidentally.
/cc @yujuhong