Node E2E: Shorten consistently check timeout of runtime conformance test #25695
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
added
area/test
priority/important-soon
k8s-github-robot
added
size/XS
pwittrock
added
the
lgtm
k8s-github-robot
removed
the
lgtm
Random-Liu
force-pushed
the
skip-runtime-conformance-test
branch
from
8eb4826
to
d1ab3b7
Compare
Random-Liu
added
release-note-none
Random-Liu
changed the title
|
@pwittrock @liangchenye Updated the PR to shorten the consistently check timeout. It turns out that the 4 * 5 * time.Minute consistently check is the root cause of long test running. |
pwittrock
added
the
lgtm
|
GCE e2e build/test passed for commit d1ab3b7. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit d1ab3b7. |
|
Automatic merge from submit-queue |
|
GCE e2e build/test passed for commit d1ab3b7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24191 increased the node e2e running time by almost half an hour. It makes the test running time exceed 60 minutes timeout, which causes quite a few issues (See #25639).
As a quite fix, we'll skip all the runtime conformance test. @liangchenye We should remove redundant test cases in #24191 such as #24191 (comment), and reduce the test running time as much as possible.