Increase goroutinemap unit test timeouts. #25955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50ms is flaky in Jenkins. Fixes kubernetes#25825
jsafrane
added
the
release-note-none
|
@swagiaal, you're the closest person who knows something about goroutinemaps, PTAL. |
k8s-github-robot
added
the
size/S
jsafrane
force-pushed
the
flake-op-timeout
branch
from
1f6ea51
to
55f9148
Compare
|
After discussion in #25825, I increased the timeout to 1 minute and removed check that |
1 similar comment
|
LGTM |
saad-ali
added
the
lgtm
|
buildcop says: this seems to make tests better and is low-risk, so marking p1. |
alex-mohr
added
the
priority/important-soon
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 55f9148. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
50ms is flaky in Jenkins. This makes the test to take at least 0.5s to check that things that should block and wait for something really do block and wait (was 100ms before).
Fixes #25825