Add some extra checking in the tests to prevent flakes. #26123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandburns
added
kind/flake
|
@jsafrane since he was also looking @ this. |
k8s-github-robot
added
size/XS
|
GCE e2e build/test passed for commit 88663fc. |
|
LGTM, thanks for the fix! |
jsafrane
added
lgtm
| // Call the tested function | ||
| err := test.test(ctrl, reactor, test) | ||
| if err != nil { | ||
| t.Errorf("Test %q initial test call failed: %v", test.name, err) | ||
| } | ||
|
|
||
| reactor.waitTest() | ||
| for reactor.getChangeCount() < count+expectedChanges[ix] { |
There was a problem hiding this comment.
@brendandburns Drive-by comment. What prevents this from entering an endless loop?
|
buildcop says: this seems to make tests better, so marking p2 so it jumps the queue. |
alex-mohr
added
the
priority/backlog
|
@alex-mohr Can somebody answer my question above before merging this please.
Q |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 88663fc. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #25967
The hypothesis is that somehow waitTest() catches an idle that occurs before all changes have been applied. This will block until the expected number of changes have arrived.