fix node.labels leak in scheduler predicates e2e #26886
Conversation
k8s-github-robot
added
size/M
| @@ -529,6 +528,14 @@ var _ = framework.KubeDescribe("SchedulerPredicates [Serial]", func() { | |||
| labelPod, err := c.Pods(ns).Get(labelPodName) | |||
| framework.ExpectNoError(err) | |||
| Expect(labelPod.Spec.NodeName).To(Equal(nodeName)) | |||
|
|
|||
| By("removing the label " + k + " off the node " + nodeName) | |||
There was a problem hiding this comment.
can you wrap this into a function?
There was a problem hiding this comment.
probably also worth doing this in a defer, as otherwise it will only run on success.
|
I agree with both of @gmarek's comments. |
| @@ -125,6 +125,24 @@ func cleanupPods(c *client.Client, ns string) { | |||
| } | |||
| } | |||
|
|
|||
| func removeLabelOffNode(c *client.Client, nodeName string, labelKey string) { | |||
| By("removing the label " + labelKey + " off the node " + nodeName) | |||
| framework.RunKubectlOrDie("label", "nodes", nodeName, labelKey+"-") | |||
There was a problem hiding this comment.
Can you please do ordinary update? Let's not depend on kubectl in this test.
There was a problem hiding this comment.
Oops, this line should be removed.
The lines following are in the way ordinary update.
gmarek
added
lgtm
kevin-wangzefeng
force-pushed
the
fix_scheduling_e2e_test_leak
branch
from
54c1a0a
to
6c335b9
Compare
k8s-github-robot
removed
the
lgtm
|
@gmarek squashed, PTAL |
|
LGTM Thanks! I'll let @gmarek apply the LGTM label if he's satisfied with the changes |
gmarek
added
the
lgtm
|
GCE e2e build/test passed for commit 6c335b9. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 6c335b9. |
|
Automatic merge from submit-queue |
closes #26698
cc @davidopp @wojtek-t @fejta @gmarek