Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/kubectl: add resource printers for rbac api group #26975

Merged
merged 1 commit into from
Jun 13, 2016
Merged

pkg/kubectl: add resource printers for rbac api group #26975

merged 1 commit into from
Jun 13, 2016

Conversation

ericchiang
Copy link
Contributor

This PR adds the necessary kubectl printers for the rbac api group which we overlooked in previous PRs.

cc @erictune

@ericchiang ericchiang force-pushed the kubectl-resource-printer-for-rbac-group branch from 485ce88 to 65f9088 Compare June 7, 2016 17:57
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Jun 7, 2016
@ericchiang ericchiang force-pushed the kubectl-resource-printer-for-rbac-group branch from 65f9088 to acfac5a Compare June 7, 2016 22:27
@ericchiang ericchiang mentioned this pull request Jun 8, 2016
Closed
@j3ffml
Copy link
Contributor

j3ffml commented Jun 8, 2016

Thanks for the pr. We're currently in code slush pending 1.3 release cut (June 10). Will take a look afterwards.

@erictune
Copy link
Member

erictune commented Jun 8, 2016

LGTM

@erictune erictune added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2016
@erictune erictune assigned erictune and unassigned j3ffml Jun 8, 2016
@erictune erictune added this to the v1.3 milestone Jun 8, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2016
@j3ffml j3ffml added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 9, 2016
@xiang90 xiang90 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 12, 2016

GCE e2e build/test passed for commit acfac5a.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 13, 2016

GCE e2e build/test passed for commit acfac5a.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 98f0d22 into kubernetes:master Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erictune erictune

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ericchiang @j3ffml @erictune @k8s-bot @k8s-github-robot @xiang90 @googlebot