Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rbac api group make subject apiversion optional #26984

Merged
merged 2 commits into from
Jun 14, 2016
Merged

Rbac api group make subject apiversion optional #26984

merged 2 commits into from
Jun 14, 2016

Conversation

ericchiang
Copy link
Contributor

@ericchiang ericchiang commented Jun 7, 2016 •
edited

This fixes the verification for the "apiVerion" field in the RBAC subject and makes it optional. This field isn't used and currently won't pass validation if it's filled.

kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1alpha1
metadata:
  name: admins
subject:
  - kind: User
    name: admin-user
    # apiVersion: "entering anything here will fail validation"
roleRef:
  kind: ClusterRole
  name: admin
  apiVersion: rbac.authorization.k8s.io/v1alpha1

@ericchiang ericchiang force-pushed the rbac-api-group-make-subject-apiversion-optional branch from 2422cc1 to aadf8ba Compare June 7, 2016 18:48
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jun 7, 2016
@ericchiang ericchiang force-pushed the rbac-api-group-make-subject-apiversion-optional branch 2 times, most recently from 45e8dc3 to 1c0c5fc Compare June 7, 2016 22:26
@ericchiang
Copy link
Contributor Author

cc @erictune

This was referenced Jun 8, 2016
Closed
Closed
@erictune erictune added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2016
@erictune erictune self-assigned this Jun 8, 2016
@erictune erictune modified the milestones: 13, v1.3 Jun 8, 2016
@erictune
Copy link
Member

erictune commented Jun 8, 2016

LGTM

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2016
@ericchiang ericchiang mentioned this pull request Jun 9, 2016
Merged
@xiang90 xiang90 added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Jun 9, 2016
@ericchiang ericchiang force-pushed the rbac-api-group-make-subject-apiversion-optional branch from 1c0c5fc to 3b24bb0 Compare June 13, 2016 16:48
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2016
@ericchiang ericchiang force-pushed the rbac-api-group-make-subject-apiversion-optional branch from 3b24bb0 to 00e76c5 Compare June 13, 2016 16:49
@ericchiang ericchiang mentioned this pull request Jun 13, 2016
Closed
@ericchiang ericchiang force-pushed the rbac-api-group-make-subject-apiversion-optional branch from 00e76c5 to 2bf54ac Compare June 13, 2016 22:02
@ericchiang
Copy link
Contributor Author

Rebased to fix some of the e2e flakiness. Need another LGTM

@erictune

@erictune
Copy link
Member

LGTM

@erictune erictune added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2016
@erictune erictune mentioned this pull request Jun 14, 2016
Closed
@erictune
Copy link
Member

Fixes #27337

@erictune erictune added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 14, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 14, 2016

GCE e2e build/test passed for commit 2bf54ac.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1a23da5 into kubernetes:master Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erictune erictune

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ericchiang @erictune @k8s-github-robot @k8s-bot @lavalamp @xiang90 @googlebot