Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shorten gc stress test #27006

Merged
merged 1 commit into from
Jun 8, 2016
Merged

shorten gc stress test #27006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/integration/garbage_collector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,9 @@ func verifyRemainingObjects(t *testing.T, clientSet clientset.Interface, rcNum,
return ret, nil
}

// This stress test the garbage collector
// The stress test is not very stressful, because we need to control the running
// time of our pre-submit tests to increase submit-queue throughput. We'll add
// e2e tests that put more stress.
func TestStressingCascadingDeletion(t *testing.T) {
t.Logf("starts garbage collector stress test")
gc, clientSet := setup(t)
Expand All @@ -357,7 +359,7 @@ func TestStressingCascadingDeletion(t *testing.T) {
go gc.Run(5, stopCh)
defer close(stopCh)

const collections = 30
const collections = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised that 30 collections takes 6 minutes to test. I'm going to LGTM this to get the running time down, but maybe you can look into seeing why it is slow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 collections is creating 120 rc and 480 pods and then deleting 120 rcs. Does that sound correct to take 6mins?

var wg sync.WaitGroup
wg.Add(collections * 4)
rcUIDs := make(chan types.UID, collections*4)
Expand Down