Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to dnsmasq:1.3 and make hyperkube always use the latest addons #27253

Merged
merged 1 commit into from
Jun 20, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions build/kube-dns/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# If you update this image please bump the tag value before pushing.
#
# Usage:
# [ARCH=amd64] [TAG=1.0] [REGISTRY=gcr.io/google_containers] [BASEIMAGE=busybox] make container
# [ARCH=amd64] [TAG=1.3] [REGISTRY=gcr.io/google_containers] [BASEIMAGE=busybox] make (container|push)

# Default registry, arch and tag. This can be overwritten by arguments to make
PLATFORM?=linux
Expand All @@ -26,7 +26,6 @@ TAG?=1.3
REGISTRY?=gcr.io/google_containers

GOLANG_VERSION=1.6
GOARM=6
KUBE_ROOT=$(shell pwd)/../..
TEMP_DIR:=$(shell mktemp -d)

Expand Down
11 changes: 6 additions & 5 deletions build/kube-dns/RELEASES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ are ready, not on every PR.

1. Build the container for testing:

`make release`
`cd build/kube-dns`
`make container PREFIX=<your-docker-hub> TAG=rc`
```
make release
cd build/kube-dns
make container PREFIX=<your-docker-hub> TAG=rc
```

2. Manually deploy this to your own cluster by updating the replication
controller and deleting the running pod(s).
Expand All @@ -18,13 +20,12 @@ are ready, not on every PR.
4. Update the TAG version in `Makefile` and update the `Changelog`. Update the
`*.yaml.in` to point to the new tag. Send a PR but mark it as "DO NOT MERGE".

5. Once the PR is approved, build and push the container for real for all architectures:
5. Once the PR is approved, build and push the container for real **for all architectures**:

```console
# Build for linux/amd64 (default)
$ make push ARCH=amd64
# ---> gcr.io/google_containers/kube-dns-amd64:TAG
# ---> gcr.io/google_containers/kube-dns:TAG (image with backwards-compatible naming)

$ make push ARCH=arm
# ---> gcr.io/google_containers/kube-dns-arm:TAG
Expand Down
6 changes: 3 additions & 3 deletions cluster/addons/addon-manager/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
IMAGE=gcr.io/google-containers/kube-addon-manager
ARCH?=amd64
TEMP_DIR:=$(shell mktemp -d)
VERSION=v2
VERSION=v3

# amd64 and arm has "stable" binaries pushed for v1.2, arm64 and ppc64le hasn't so they have to fetch the latest alpha
# however, arm64 and ppc64le are very experimental right now, so it's okay
Expand All @@ -29,12 +29,12 @@ ifeq ($(ARCH),arm)
QEMUARCH=arm
endif
ifeq ($(ARCH),arm64)
KUBECTL_VERSION?=v1.3.0-alpha.3
KUBECTL_VERSION?=v1.3.0-beta.0
BASEIMAGE?=aarch64/python:2.7-slim
QEMUARCH=aarch64
endif
ifeq ($(ARCH),ppc64le)
KUBECTL_VERSION?=v1.3.0-alpha.3
KUBECTL_VERSION?=v1.3.0-alpha.4
BASEIMAGE?=ppc64le/python:2.7-slim
QEMUARCH=ppc64le
endif
Expand Down
3 changes: 1 addition & 2 deletions cluster/addons/dashboard/dashboard-controller.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# This file should be kept in sync with cluster/images/hyperkube/dashboard-rc.yaml
# and cluster/gce/coreos/kube-manifests/addons/dashboard/dashboard-controller.yaml
# This file should be kept in sync with cluster/gce/coreos/kube-manifests/addons/dashboard/dashboard-controller.yaml
apiVersion: v1
kind: ReplicationController
metadata:
Expand Down
3 changes: 1 addition & 2 deletions cluster/addons/dashboard/dashboard-service.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# This file should be kept in sync with cluster/images/hyperkube/dashboard-svc.yaml
# and cluster/gce/coreos/kube-manifests/addons/dashboard/dashboard-service.yaml
# This file should be kept in sync with cluster/gce/coreos/kube-manifests/addons/dashboard/dashboard-service.yaml
apiVersion: v1
kind: Service
metadata:
Expand Down
11 changes: 9 additions & 2 deletions cluster/images/hyperkube/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# Usage:
# [ARCH=amd64] [REGISTRY="gcr.io/google_containers"] make (build|push) VERSION={some_version_number e.g. v1.2.0}

REGISTRY?="gcr.io/google_containers"
REGISTRY?=gcr.io/google_containers
ARCH?=amd64
TEMP_DIR:=$(shell mktemp -d)
CNI_RELEASE=c864f0e1ea73719b8f4582402b0847064f9883b0
Expand Down Expand Up @@ -54,16 +54,23 @@ ifndef VERSION
$(error VERSION is undefined)
endif
cp -r ./* ${TEMP_DIR}
mkdir -p ${TEMP_DIR}/cni
mkdir -p ${TEMP_DIR}/cni ${TEMP_DIR}/addons
cp ../../saltbase/salt/helpers/safe_format_and_mount ${TEMP_DIR}
cp ../../saltbase/salt/generate-cert/make-ca-cert.sh ${TEMP_DIR}
cp ../../saltbase/salt/kube-dns/skydns-rc.yaml.base ${TEMP_DIR}/addons/skydns-rc.yaml
cp ../../saltbase/salt/kube-dns/skydns-svc.yaml.base ${TEMP_DIR}/addons/skydns-svc.yaml
cp ../../addons/dashboard/dashboard-controller.yaml ${TEMP_DIR}/addons
cp ../../addons/dashboard/dashboard-service.yaml ${TEMP_DIR}/addons
cp kube-proxy-ds.yaml ${TEMP_DIR}/addons/kube-proxy.yaml
cp ../../../_output/dockerized/bin/linux/${ARCH}/hyperkube ${TEMP_DIR}

cd ${TEMP_DIR} && sed -i.back "s|VERSION|${VERSION}|g" addons/*.yaml static-pods/*.json
cd ${TEMP_DIR} && sed -i.back "s|REGISTRY|${REGISTRY}|g" addons/*.yaml static-pods/*.json
cd ${TEMP_DIR} && sed -i.back "s|ARCH|${ARCH}|g" addons/*.yaml static-pods/*.json
cd ${TEMP_DIR} && sed -i.back "s|ARCH|${QEMUARCH}|g" Dockerfile
cd ${TEMP_DIR} && sed -i.back "s|BASEIMAGE|${BASEIMAGE}|g" Dockerfile
cd ${TEMP_DIR} && sed -i.back "s|-amd64|-${ARCH}|g" addons/*.yaml
cd ${TEMP_DIR} && sed -i.back "s|__PILLAR__DNS__REPLICAS__|1|g;s|__PILLAR__DNS__SERVER__|10.0.0.10|g;s|__PILLAR__DNS__DOMAIN__|cluster.local|g" addons/skydns*.yaml
rm ${TEMP_DIR}/addons/*.back

# Make scripts executable before they are copied into the Docker image. If we make them executable later, in another layer
Expand Down
51 changes: 0 additions & 51 deletions cluster/images/hyperkube/addons/dashboard-rc.yaml

This file was deleted.

29 changes: 0 additions & 29 deletions cluster/images/hyperkube/addons/dashboard-svc.yaml

This file was deleted.

110 changes: 0 additions & 110 deletions cluster/images/hyperkube/addons/dns-rc.yaml

This file was deleted.

35 changes: 0 additions & 35 deletions cluster/images/hyperkube/addons/dns-svc.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion cluster/images/hyperkube/static-pods/addon-manager.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"containers": [
{
"name": "kube-addon-manager",
"image": "gcr.io/google-containers/kube-addon-manager-ARCH:v2",
"image": "gcr.io/google-containers/kube-addon-manager-ARCH:v3",
"resources": {
"requests": {
"cpu": "5m",
Expand Down
10 changes: 5 additions & 5 deletions cluster/saltbase/salt/kube-dns/skydns-rc.yaml.base
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,22 @@
apiVersion: v1
kind: ReplicationController
metadata:
name: kube-dns-v14
name: kube-dns-v15
namespace: kube-system
labels:
k8s-app: kube-dns
version: v14
version: v15
kubernetes.io/cluster-service: "true"
spec:
replicas: __PILLAR__DNS__REPLICAS__
selector:
k8s-app: kube-dns
version: v14
version: v15
template:
metadata:
labels:
k8s-app: kube-dns
version: v14
version: v15
kubernetes.io/cluster-service: "true"
spec:
containers:
Expand Down Expand Up @@ -83,7 +83,7 @@ spec:
name: dns-tcp-local
protocol: TCP
- name: dnsmasq
image: gcr.io/google_containers/dnsmasq:1.1
image: gcr.io/google_containers/kube-dnsmasq-amd64:1.3
args:
- --cache-size=1000
- --no-resolv
Expand Down