portforward e2e: extend log for flake hunting #27766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
added
area/test
kind/flake
k8s-github-robot
added
the
size/M
|
GCE e2e build/test passed for commit 1beb2b3. |
|
@ixdy ptal |
| @@ -183,6 +183,14 @@ var _ = framework.KubeDescribe("Port forwarding", func() { | |||
| if err := f.WaitForPodRunning(pod.Name); err != nil { | |||
| framework.Failf("Pod did not start running: %v", err) | |||
| } | |||
| defer func() { | |||
| logs, err := framework.GetPodLogs(f.Client, f.Namespace.Name, pod.Name, "portforwardtester") | |||
There was a problem hiding this comment.
how spammy are these logs? will it be annoying to dump them even in success conditions?
ixdy
added
the
lgtm
|
GCE e2e build/test passed for commit 1beb2b3. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 1beb2b3. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some more insight into flake #27680