Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MountPath in VolumeMount is a required field. Removing the omitempty. #2820

Merged
merged 1 commit into from
Dec 11, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/api/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ type VolumeMount struct {
// Optional: Defaults to false (read-write).
ReadOnly bool `json:"readOnly,omitempty"`
// Required.
MountPath string `json:"mountPath,omitempty"`
MountPath string `json:"mountPath"`
}

// EnvVar represents an environment variable present in a Container.
Expand Down
2 changes: 1 addition & 1 deletion pkg/api/v1beta1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ type VolumeMount struct {
// Required.
// Exactly one of the following must be set. If both are set, prefer MountPath.
// DEPRECATED: Path will be removed in a future version of the API.
MountPath string `json:"mountPath,omitempty" description:"path within the container at which the volume should be mounted; overrides path"`
MountPath string `json:"mountPath" description:"path within the container at which the volume should be mounted; overrides path"`
Path string `json:"path,omitempty" description:"path within the container at which the volume should be mounted; deprecated"`
// One of: "LOCAL" (local volume) or "HOST" (external mount from the host). Default: LOCAL.
// DEPRECATED: MountType will be removed in a future version of the API.
Expand Down
2 changes: 1 addition & 1 deletion pkg/api/v1beta2/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ type VolumeMount struct {
// Optional: Defaults to false (read-write).
ReadOnly bool `json:"readOnly,omitempty" description:"mounted read-only if true, read-write otherwise (false or unspecified)"`
// Required.
MountPath string `json:"mountPath,omitempty" description:"path within the container at which the volume should be mounted"`
MountPath string `json:"mountPath" description:"path within the container at which the volume should be mounted"`
}

// EnvVar represents an environment variable present in a Container.
Expand Down
2 changes: 1 addition & 1 deletion pkg/api/v1beta3/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ type VolumeMount struct {
// Optional: Defaults to false (read-write).
ReadOnly bool `json:"readOnly,omitempty"`
// Required.
MountPath string `json:"mountPath,omitempty"`
MountPath string `json:"mountPath"`
}

// EnvVar represents an environment variable present in a Container.
Expand Down