First step of optimizing PodAffinity priority function #28952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-t
added
do-not-merge
k8s-github-robot
added
the
size/L
wojtek-t
force-pushed
the
optimize_pod_affinity
branch
from
0f6615a
to
8c9fee5
Compare
wojtek-t
removed
the
do-not-merge
wojtek-t
changed the title
| @@ -0,0 +1,95 @@ | |||
| /* | |||
There was a problem hiding this comment.
@davidopp - I splitted non_zero.go file into two parts - this is mostly copy of that with some small changes.
|
My only comments are suggestions for additional comments to add, so that if the next person who reads this code is as dumb as me, it will at least take them less time to understand it than it did for me. :) After you add the comments, you can apply LGTM label. Thanks! |
wojtek-t
force-pushed
the
optimize_pod_affinity
branch
from
8c9fee5
to
a538045
Compare
|
Comments applied - thanks @davidopp ! |
wojtek-t
added
the
lgtm
|
GCE e2e build/test passed for commit a538045. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit a538045. |
|
Automatic merge from submit-queue |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #26144
This is obviously only a first step - I will continue working on this code. However, this is changing the general scheme of computations to what is described in: #26144 (comment)