Optimize pod affinity 2 #29379
Merged
Optimize pod affinity 2 #29379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-t
added
do-not-merge
k8s-github-robot
added
the
size/L
wojtek-t
force-pushed
the
optimize_pod_affinity_2
branch
from
daf2315
to
88ca042
Compare
k8s-github-robot
added
the
needs-rebase
wojtek-t
force-pushed
the
optimize_pod_affinity_2
branch
from
88ca042
to
9d9e686
Compare
k8s-github-robot
removed
the
needs-rebase
wojtek-t
force-pushed
the
optimize_pod_affinity_2
branch
from
9d9e686
to
84a24bf
Compare
k8s-github-robot
added
the
needs-rebase
wojtek-t
force-pushed
the
optimize_pod_affinity_2
branch
from
84a24bf
to
bcf30f5
Compare
k8s-github-robot
removed
the
needs-rebase
| node *api.Node | ||
| } | ||
|
|
||
| func PredicateMetadata(pod *api.Pod, nodeInfoMap map[string]*schedulercache.NodeInfo) interface{} { | ||
| if pod == nil { | ||
| // We cannot compute metadata, just return nil |
There was a problem hiding this comment.
move this comment to the top of the function since now it applies to more than one return
|
Just had a couple of comments. |
wojtek-t
force-pushed
the
optimize_pod_affinity_2
branch
from
8807972
to
4bc410e
Compare
wojtek-t
removed
the
do-not-merge
|
OK - I did some experiments and it seems that from performance point of view it's good enough for now to have this merged. |
|
GCE e2e build/test passed for commit 4bc410e. |
davidopp
added
the
lgtm
|
LGTM |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 4bc410e. |
|
Automatic merge from submit-queue |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #26144