DNS templates cleanups #29720
DNS templates cleanups #29720
Conversation
thockin
added
the
release-note-none
k8s-github-robot
added
size/L
|
@thockin agree: what we have today for libvirt is not reliable. Having a look to see if we can pull the real ones. Thanks |
|
@thockin Yes we can look at ways to keep current with the skydns files. We use templating logic to pass in user defined configuration so we will have to investigate what we can do. |
k8s-github-robot
added
the
needs-rebase
|
LGTM |
| for the config variables mentioned above. Other than the templating, these are | ||
| normal kubernetes objects, and can be instantiated with `kubectl create`. | ||
| the example files | ||
| ([ReplicationController](../../cluster/addns/dns/kubedns-rc.yaml.sed) and |
There was a problem hiding this comment.
@thockin typo: ../../cluster/addons/dns/...
thockin
removed
do-not-merge
|
Girish said LGTM |
thockin
added
the
lgtm
Automatic merge from submit-queue libvirt_coreos: to remove old skydns fork fetching from addons @thockin @girishkalele ref #29720. Goal of this PR is: - to remove obsolete DNS config files. - to propose a way to fetch the real template As soon #29720 will be merged I'm OK to modify this accordingly. FYI: @lhuard1A
k8s-github-robot
removed
the
lgtm
thockin
added
the
lgtm
Automatic merge from submit-queue Replacing skydns with kubedns for the juju cluster. #29720 ```release-note * Updating the cluster/juju provider to use kubedns in place of skydns. ```
k8s-github-robot
added
the
needs-rebase
Rename *.in to *.jinja - it's clearer and more precise. Fix a couple cases to use the .sed files rather than the .in files.
|
I've resigned myself to needing to basically recreate this after other On Tue, Sep 13, 2016 at 10:11 AM, Girish Kalele notifications@github.com
|
|
@thockin The plan is to use some facilities in https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/trusty/configure-helper.sh#L864-L888 /cc @euank , since you are reworking the kube-up for coreos/rkt using hyperkube image, you might have a chance to touch this. |
|
Thanks for the ping @yifan-gu, I'm working on getting our addons to use the shared base now |
|
PR above, I deleted the Once that's merged, that copy of the DNS templates should be much more maintainable (aka gone) :) |
|
ok to test pr builder appears to be missing, activating due to 'lgtm' label. |
8 similar comments
|
ok to test pr builder appears to be missing, activating due to 'lgtm' label. |
|
ok to test pr builder appears to be missing, activating due to 'lgtm' label. |
|
ok to test pr builder appears to be missing, activating due to 'lgtm' label. |
|
ok to test pr builder appears to be missing, activating due to 'lgtm' label. |
|
ok to test pr builder appears to be missing, activating due to 'lgtm' label. |
|
ok to test pr builder appears to be missing, activating due to 'lgtm' label. |
|
ok to test pr builder appears to be missing, activating due to 'lgtm' label. |
|
ok to test pr builder appears to be missing, activating due to 'lgtm' label. |
|
Jenkins GKE smoke e2e failed for commit 6dbfe2a. Full PR test history. The magic incantation to run this job again is |
|
Jenkins GCI GKE smoke e2e failed for commit 6dbfe2a. Full PR test history. The magic incantation to run this job again is |
|
Jenkins GCE e2e failed for commit 6dbfe2a. Full PR test history. The magic incantation to run this job again is |
|
Jenkins Kubemark GCE e2e failed for commit 6dbfe2a. Full PR test history. The magic incantation to run this job again is |
…ud-init Automatic merge from submit-queue Coreos kube-up now with less cloud init This update includes significant refactoring. It moves almost all of the logic into bash scripts, modeled after the `gci` cluster scripts. The reason to do this is: 1. Avoid duplicating the saltbase manifests by reusing gci's parsing logic (easier maintenance) 2. Take an incremental step towards sharing more code between gci/trusty/coreos, again for better maintenance 3. Pave the way for making future changes (e.g. improved rkt support, kubelet support) easier to share The primary differences from the gci scripts are the following: 1. Use of the `/opt/kubernetes` directory over `/home/kubernetes` 2. Support for rkt as a runtime 3. No use of logrotate 4. No use of `/etc/default/` 5. No logic related to noexec mounts or gci-specific firewall-stuff It will make sense to move 2 over to gci, as well as perhaps a few other small improvements. That will be a separate PR for ease of review. Ref #29720, this is a part of that because it removes a copy of them. Fixes #24165 cc @yifan-gu Since this logic largely duplicates logic from the gci folder, it would be nice if someone closely familiar with that gave an OK or made sure I didn't fall into any gotchas related to that, so cc @andyzheng0831
This is a set of cleanups to the DNS templates that are used to configure the kubedns addon. It should be reviewed commit-by-commit.
Missing from this are a handful of directories that still have old references to "skydns" names.
@errordeveloper : you are the major author of
docs/getting-started-guides/coreos/azure/addons/skydns-*. These files are ANCIENT forks of the DNS config files. We can not really have this in our docs. Can we find a way to pull from the real template files? This is in both the main repo and teh docs repo while docs are converting.@yifan-gu : you are the major author of
cluster/gce/coreos/kube-manifests/addons/dns/skydns-*. These files are forks of the DNS config files, and are drifting out of sync. We can not really have this. Can we find a way to pull from the real template files instead?@mbruzek @chuckbutler : you are the major authors of
cluster/juju/layers/kubernetes/templates/skydns-*. These files are ANCIENT forks of the DNS config files. We can not really have this. Can we find a way to pull from the real template files instead?@sdminonne : you are the major author of
cluster/libvirt-coreos/skydns-*. These files are ANCIENT forks of the DNS config files. We can not really have this. Can we find a way to pull from the real template files instead?This change is