fix nodeAffinity e2e file not exist failure #30061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @gmarek @ixdy @jayunit100 |
|
Labelling this PR as size/XS |
k8s-github-robot
added
size/XS
|
I wrote #30060 which removes kubectl call from the path to avoid such problem in the future. We just shouldn't use it in tests other that kubectl ones. Thanks for writing it though:) |
|
GCE e2e build/test passed for commit d7982a2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #25584 (comment) and #30018 (comment)
#25584 removed repoRoot in scheduler_predicates e2e test.
Using relative path doesn't work. And I checked the filepath that currently
kubectl create -fuses intest\e2e\examples.go,test\e2e\ingress.goandtest\e2e\petset.go, they are still using repoRoot to generate make filepath.This PR is to revert the change that #25584 did in scheduler_predicates.go