Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the series and the README to reflect the change. #30374

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

mbruzek
Copy link
Contributor

@mbruzek mbruzek commented Aug 10, 2016

This PR updates the juju charm code to support the latest series (xenial 16.04). We changed the README to reflect this change and how that changes the juju commands.

fixes #30373

release-note-none


This change is Reviewable

@k8s-bot
Copy link

k8s-bot commented Aug 10, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

4 similar comments
@k8s-bot
Copy link

k8s-bot commented Aug 10, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Aug 10, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Aug 10, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Aug 10, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Aug 10, 2016
@lazypower
Copy link
Contributor

This looks good at first glance however, the additional layers it depends on look like they need some Xenial updates as well.

Namely, layer-flannel which has no systemD support templates. I'll get those hacked together and test this PR and +1 when I've got a confirmed working build.

@k8s-bot
Copy link

k8s-bot commented Aug 11, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@lazypower
Copy link
Contributor

with juju-solutions/layer-flannel#17 landed, and i've been kicking the tires on it and running tests, I think we're good to go on this bumping up to Xenail now

+1 LGTM

Thanks for the work here @mbruzek

@castrojo
Copy link
Member

+1 LGTM, I had a question about why we weren't being explicit, juju deploy kubernetes vs juju deploy xenial/kubernetes but Matt explained that the charm metadata handles this now so it states what the supported series is, no need for the user to define it.

@k8s-bot
Copy link

k8s-bot commented Aug 16, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@zmerlynn zmerlynn added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Aug 16, 2016
@zmerlynn
Copy link
Member

:lgtm:


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 16, 2016

GCE e2e build/test passed for commit 9673ceb.

@mbruzek
Copy link
Contributor Author

mbruzek commented Aug 29, 2016

@pwittrock in accordance with the Criteria for getting something into 1.4 post on google groups: https://groups.google.com/forum/#!msg/kubernetes-dev/pdMJpA0NF7I/1dXrRBriCQAJ here are the three questions with answers:

  1. How risky is it to merge this change?
    Answer: This change is very low risk, as it is labeled a "small" change and is mostly documentation. Only one code change for the Juju layer configuration.
  2. How easy is it to roll this change back?
    Answer: The change is very easy to roll back, one commit, and only 2 files changed.
  3. What's the cost if it doesn't make the 1.4 release?
    Answer: The documentation for the juju cluster component will be incorrect and we will not be able to give people the proper steps to take in the README file.

Please consider this small PR for the exception process to get in before 1.4. Thank you Phil.

@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@mbruzek
Copy link
Contributor Author

mbruzek commented Sep 28, 2016

This PR was locked out for the 1.4.0 freeze. We should keep this open to complete the review. I do not have permission to add labels yet. Please add the 'keep-open' label.

@zmerlynn
Copy link
Member

@k8s-bot test this

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 9673ceb. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@mbruzek
Copy link
Contributor Author

mbruzek commented Oct 12, 2016

I signed the cla for the linuxfoundation today, and see the tests were failing to queue. How does one trigger a retest?

@lazypower
Copy link
Contributor

lazypower commented Oct 12, 2016

I'm going to try this:

@k8s-bot test this

-edit- looks like its failing to queue the builds (temporarily) when I told it to try that. So I'm not sure if infra related (maintenance) or if i'm carrying super cosmic bot error powers. But it did recover gracefully. so +1 to that - we'll see whats up after this run

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 9673ceb. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@lazypower
Copy link
Contributor

I looked through the smoke-test failure logs and they dont appear related. I saw some infra 404's, and a rocket turnup daemon connect failure (which we aren't exercising in this pr). I feel these failures are not due in part to this change.

Therefore this is +1 LGTM. @zmerlynn is it cool for us to land this or do we need a satisfactory smoke test before we can land it?

@zmerlynn
Copy link
Member

@chuckbutler: You won't even get to the submit queue without the tests being green, though I just threw on retest-not-required to ensure SQ doesn't touch it again.

@k8s-bot cvm gke e2e test this
@k8s-bot gci gke e2e test this

@zmerlynn
Copy link
Member

@chuckbutler: SQ == submit queue. That label stops the submit queue from retesting it before merging, which it normally would, but we don't have any PR-builder tests that are influenced by what's touched in this code. As a human, I can vet that and label it so the SQ isn't wasting time retesting something.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 9673ceb. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 049a023 into kubernetes:master Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Juju charms for k8s should use the latest LTS
8 participants