Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestPidOf {procfs} #30377

Closed
k8s-github-robot opened this issue Aug 10, 2016 · 10 comments
Closed

TestPidOf {procfs} #30377

k8s-github-robot opened this issue Aug 10, 2016 · 10 comments
Assignees
@dims
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@k8s-github-robot
Copy link

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/15578/

Failed: TestPidOf {procfs}

panic: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:481 +0x3ff
/usr/local/go/src/testing/testing.go:467 +0x22a
/usr/local/go/src/runtime/panic.go:443 +0x521
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs.go:70 +0xb2
/usr/local/go/src/path/filepath/path.go:370 +0x4e8
/usr/local/go/src/path/filepath/path.go:396 +0x107
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs.go:104 +0x17b
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs_test.go:69 +0xb0
/usr/local/go/src/testing/testing.go:473 +0xdd
/usr/local/go/src/testing/testing.go:582 +0xae3
@k8s-github-robot k8s-github-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/flake Categorizes issue or PR as related to a flaky test. labels Aug 10, 2016
@k8s-github-robot
Copy link
Author

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/15583/

Failed: TestPidOf {procfs}

panic: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:481 +0x3ff
/usr/local/go/src/testing/testing.go:467 +0x22a
/usr/local/go/src/runtime/panic.go:443 +0x521
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs.go:70 +0xb2
/usr/local/go/src/path/filepath/path.go:370 +0x4e8
/usr/local/go/src/path/filepath/path.go:396 +0x107
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs.go:104 +0x17b
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs_test.go:69 +0xb0
/usr/local/go/src/testing/testing.go:473 +0xdd
/usr/local/go/src/testing/testing.go:582 +0xae3

@derekwaynecarr derekwaynecarr mentioned this issue Aug 10, 2016
Merged
@yujuhong yujuhong assigned dims and unassigned apelisse Aug 10, 2016
@yujuhong
Copy link
Contributor

@dims could you take a look? Thanks.

dims added a commit to dims/kubernetes that referenced this issue Aug 10, 2016
@dims
Fix intermittent failures in TestPidOf {procfs}
e1ad642 
Bailout if WalkFunc is called with an error.

Fixes kubernetes#30377
@dims dims mentioned this issue Aug 10, 2016
Merged
@Q-Lee Q-Lee mentioned this issue Aug 10, 2016
Merged
@k8s-github-robot
Copy link
Author

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/15596/

Failed: TestPidOf {procfs}

panic: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:481 +0x3ff
/usr/local/go/src/testing/testing.go:467 +0x22a
/usr/local/go/src/runtime/panic.go:443 +0x521
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs.go:70 +0xb2
/usr/local/go/src/path/filepath/path.go:370 +0x4e8
/usr/local/go/src/path/filepath/path.go:396 +0x107
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs.go:104 +0x17b
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs_test.go:69 +0xb0
/usr/local/go/src/testing/testing.go:473 +0xdd
/usr/local/go/src/testing/testing.go:582 +0xae3

@k8s-github-robot k8s-github-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 11, 2016
@madhusudancs madhusudancs mentioned this issue Aug 11, 2016
Merged
@k8s-github-robot
Copy link
Author

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/15609/

Failed: TestPidOf {procfs}

panic: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:481 +0x3ff
/usr/local/go/src/testing/testing.go:467 +0x22a
/usr/local/go/src/runtime/panic.go:443 +0x521
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs.go:70 +0xb2
/usr/local/go/src/path/filepath/path.go:370 +0x4e8
/usr/local/go/src/path/filepath/path.go:396 +0x107
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs.go:104 +0x17b
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/procfs/procfs_test.go:69 +0xb0
/usr/local/go/src/testing/testing.go:473 +0xdd
/usr/local/go/src/testing/testing.go:582 +0xae3

@k8s-github-robot k8s-github-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 11, 2016
@soltysh soltysh mentioned this issue Aug 11, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 11, 2016
Merge pull request #30402 from dims/fix-issue-30377
342aac2 
Automatic merge from submit-queue

Fix intermittent failures in TestPidOf {procfs}

Bailout if WalkFunc is called with an error.

Fixes #30377

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30402)
<!-- Reviewable:end -->
@lavalamp
Copy link
Member

lavalamp commented Aug 11, 2016 •
edited

@dims-- I still am getting errors in this test even after rebasing-- https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/25526/kubernetes-pull-test-unit-integration/38956/

@lavalamp lavalamp reopened this Aug 11, 2016
@k8s-github-robot
Copy link
Author

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/15631/

Failed: TestPidOf {procfs}

<autogenerated>:31: 

    Error Trace:    procfs_test.go:71

    Error:      "[]" does not contain "%!s(int=16490)"

dims added a commit to dims/kubernetes that referenced this issue Aug 11, 2016
@dims
Fix TestPidOf {procfs} - Take #2
24e8e12 
We should not bailout when we get an error. We should continue
processing other files/directories. We were returning the
err passed in which was causing the processing to stop.

Fixes kubernetes#30377
@dims dims mentioned this issue Aug 11, 2016
Merged
@dims
Copy link
Member

dims commented Aug 11, 2016

@lavalamp Looks like i read the godoc wrong and was returning the error causing the processing to stop. filed another PR #30478

@dchen1107 dchen1107 mentioned this issue Aug 11, 2016
Merged
@k8s-github-robot
Copy link
Author

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/15640/

Failed: TestPidOf {procfs}

<autogenerated>:31: 

    Error Trace:    procfs_test.go:71

    Error:      "[]" does not contain "%!s(int=16530)"

@k8s-github-robot
Copy link
Author

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/15646/

Failed: TestPidOf {procfs}

<autogenerated>:31: 

    Error Trace:    procfs_test.go:71

    Error:      "[]" does not contain "%!s(int=16561)"

@k8s-github-robot
Copy link
Author

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/15661/

Failed: TestPidOf {procfs}

<autogenerated>:31: 

    Error Trace:    procfs_test.go:71

    Error:      "[]" does not contain "%!s(int=16713)"

@caesarxuchao caesarxuchao mentioned this issue Aug 12, 2016
Merged
@mtaufen mtaufen mentioned this issue Aug 12, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 12, 2016
Merge pull request #30478 from dims/fix-test-pidof-take-2
5992ded 
Automatic merge from submit-queue

Fix TestPidOf {procfs} - Take #2

We should not bailout when we get an error. We should continue
processing other files/directories. We were returning the
err passed in which was causing the processing to stop.

Fixes #30377
@jsafrane jsafrane mentioned this issue Aug 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dims dims

Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dims @lavalamp @apelisse @yujuhong @k8s-github-robot