Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet: implement GetNetNS for new runtime api #31091

Merged
merged 1 commit into from
Aug 24, 2016

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Aug 22, 2016

Kubelet: implement GetNetNS for new runtime api.

CC @yujuhong @thockin @kubernetes/sig-node @kubernetes/sig-rktnetes


This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-label-needed labels Aug 22, 2016
@feiskyer
Copy link
Member Author

@k8s-bot test this please, issue #31079.

@yujuhong
Copy link
Contributor

+release-note-none -release-note-label-needed

LGTM


Reviewed 9 of 9 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@yujuhong yujuhong added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Aug 22, 2016
@feiskyer
Copy link
Member Author

Rebased since #30121 has been merged.

@yujuhong yujuhong assigned yujuhong and unassigned vishh Aug 22, 2016
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 22, 2016
@yujuhong
Copy link
Contributor

+lgtm


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 23, 2016

GCE e2e build/test passed for commit df00ec0.

@lavalamp lavalamp modified the milestones: v1.5, v1.4 Aug 23, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 24, 2016

GCE e2e build/test passed for commit df00ec0.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f488d11 into kubernetes:master Aug 24, 2016
@feiskyer feiskyer deleted the kuberuntime-getnetns branch August 24, 2016 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants