New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Operational Actions to the Kubernetes layer #31202

Closed

lazypower wants to merge 3 commits into kubernetes:master from lazypower:ops-pause-resume-actions

Contributor

lazypower commented Aug 23, 2016 •

edited by k8s-oncall

What this PR does / why we need it:

This PR adds management actions to the Kubernetes charm to cordon/drain nodes, as well as resume operation once the action(s) have been taken.

Special notes for your reviewer:

If you wish to test these actions, feel free to deploy

export KUBERNETES_PROVIDER=juju
cluster/kube-up.sh
... once deployed ...
juju run-action kubernetes/0 microbot replicas=15
juju run-action kubernetes/1 pause
... verify unit is cordoned, and drained ...
juju run-action kubernetes/1 resume

Release note:

Adds operational actions to the juju charm layer - pause/resume

This change is


          Adds Operational Actions to the Kubernetes layer

f1424da

 - pause - will cordon and drain a node forcefully
 - resume - will uncordon a node
 - microbot - Deploys a set number of pods to illustrate the operational
   actions

googlebot added the cla: yes label

k8s-bot commented Aug 23, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Contributor Author

lazypower commented Aug 23, 2016

@mbruzek When you have a moment, would you mind taking a look over this PR and ensure its sane? It works well for me in testing.

k8s-bot commented Aug 23, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

5 similar comments

k8s-bot commented Aug 23, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

k8s-bot commented Aug 23, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

k8s-bot commented Aug 23, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

k8s-bot commented Aug 23, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

k8s-bot commented Aug 23, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.


          Fixed a grammatical error

9117cdb

k8s-github-robot assigned zmerlynn

k8s-github-robot added size/M release-note-label-needed labels


          Adds actions descriptions to the README

9bd4da1

Updates the action descriptions for a crisper CLI output. THe longer
descriptions were word-wrapping and didn't add much value to the text.
Longer descriptions have been moved to the README.

Contributor

marcoceppi commented Aug 23, 2016

👍 from me, tested locally

Contributor Author

lazypower commented Aug 23, 2016

@zmerlynn I forgot if the project prefers single squashed commits. Let me know and I'll update accordingly.

Member

castrojo commented Aug 23, 2016

LGTM, tested on GCE.

Contributor

mbruzek commented Sep 23, 2016

We still need this PR to land. We got stuck in the v1.4.0 freeze and now our PR is timing out? Can someone add the 'keep-open' label, I can't add labels.

Contributor

mbruzek commented Oct 12, 2016

@kubebot "ok to test"

mbruzek approved these changes

View reviewed changes

Contributor

mbruzek left a comment

+1 LGTM

Contributor Author

lazypower commented Oct 14, 2016

I'm going to close this PR as its superseded by other work and is now stale. The new work will be proposed against kubernetes proper sooner rather than continue to ride this PR against a layer we are deprecating.

lazypower closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment