add selfsubjectaccessreview API #31271
Conversation
k8s-github-robot
added
kind/api-change
|
@krousey I suspect that @ericchiang is a better fit given the area. I'm adding him. |
| @@ -38,6 +38,10 @@ type SubjectAccessReview struct { | |||
| Status SubjectAccessReviewStatus | |||
| } | |||
|
|
|||
| // +genclient=true | |||
| // +nonNamespaced=true | |||
| // +noMethods=true | |||
There was a problem hiding this comment.
Sorry, I couldn't find documentation on what +noMethods accomplishes. Does it limit the actions generated to "Create"?
There was a problem hiding this comment.
Sorry, I couldn't find documentation on what +noMethods accomplishes. Does it limit the actions generated to "Create"?
It prevents the client generator from generating methods. Since this isn't a normal resource, it doesn't have types for things like SelfSubjectAccessReviewList (no get method), so the default generator fails.
It means you have to manually create the Create methods in the generated_expansion.go file.
There was a problem hiding this comment.
It means you have to manually create the Create methods in the generated_expansion.go file.
Nice. Does that not get overridden as soon as someone else regenerates? (not to get too off topic)
There was a problem hiding this comment.
Nice. Does that not get overridden as soon as someone else regenerates? (not to get too off topic)
No, it is preserved.
|
Don't know what's up with the integration tests but lgtm |
deads2k
added
release-note
deads2k
added
the
lgtm
k8s-github-robot
added
the
needs-rebase
deads2k
added
lgtm
k8s-github-robot
removed
the
needs-rebase
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
GCE e2e build/test passed for commit 2f642eb. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 2f642eb. |
|
Automatic merge from submit-queue |
Exposes the REST API for self subject access reviews. This allows a user to see whether or not they can perform a particular action.
@kubernetes/sig-auth
This change is