Supporting snapshots in volume plugins #31373
Conversation
k8s-github-robot
added
kind/api-change
| DeleteFunc: sc.pvcDelete, | ||
| }) | ||
|
|
||
| if err := sc.volumePluginMgr.InitPlugins(plugins, sc); err != nil { |
There was a problem hiding this comment.
@saad-ali Is that ok we InitPlugins twice, the other one is in attachdetacher?
There was a problem hiding this comment.
Ideally it should be called once per binary, but since they are separate instances it won't cause any problems. We should refactor this in the future.
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
ok to test |
|
|
||
| // PostEventToPersistentVolumeClaim posts an event to the given PersistentVolumeClaim | ||
| // API object with the given message and event type. | ||
| func PostEventToPersistentVolumeClaim( |
There was a problem hiding this comment.
We should use recorder.Eventf to post events because it will take care of the duplicate events too
|
GCE e2e build/test passed for commit a6ec722. |
|
@ciwang PR needs rebase |
k8s-github-robot
added
the
needs-rebase
What this PR does / why we need it:
Support snapshots of persistent volumes by adding a new volume plugin interface and a new snapshot controller that handles snapshot requests on PVCs.
https://docs.google.com/document/d/10vDELyIAcgeRGFEgGZ1el78jrf_z2z_2QmQsH4enfhA/edit#heading=h.5vmingbzqhas
Which issue this PR fixes (optional, in
fixes #<issue number>(, #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note:
This change is