kubectl: cast notFound error to struct

[0xmichalis]

Fixes #28378 (the 404 flake)

@kubernetes/kubectl @kubernetes/deployment

---

This change is

[0xmichalis]

@k8s-bot test this issue: #31389

[adohe-zz]

pkg/kubectl/stop_test.go, line 774 [r1] (raw file):

  reaper := DeploymentReaper{fake, time.Millisecond, time.Millisecond}
  err := reaper.Stop(ns, name, 0, nil)
  fmt.Println(fake.Actions())

Please remove this println, and maybe we can simply check actions.

---

Comments from Reviewable

[0xmichalis]

Done.

On Thu, Aug 25, 2016 at 1:53 AM, TonyAdo notifications@github.com wrote:

pkg/kubectl/stop_test.go, line 774 [r1]
https://reviewable.kubernetes.io:443/reviews/kubernetes/kubernetes/31375#-KPyxvUHs1ljqjHha7tL:-KPyxvUHs1ljqjHha7tM:bft3lwu
(raw file

kubernetes/pkg/kubectl/stop_test.go

Line 774 in 9667b47

fmt.Println(fake.Actions())

):

reaper := DeploymentReaper{fake, time.Millisecond, time.Millisecond}
err := reaper.Stop(ns, name, 0, nil)
fmt.Println(fake.Actions())

Please remove this println, and maybe we can simply check actions.

Comments from Reviewable
https://reviewable.kubernetes.io:443/reviews/kubernetes/kubernetes/31375

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#31375 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADuFf5KhUkLkGGyZpSfk_RN7R7WFWrcdks5qjNlrgaJpZM4JsbRM
.

[k8s-bot]

GCE e2e build/test passed for commit 4c56b8c.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

[adohe-zz]

---

Comments from Reviewable

[adohe-zz]

---

Comments from Reviewable

[0xmichalis]

@pwittrock @gmarek this fixes the 404 in #28378 (missed from #29484). Should we add a 1.4 milestone?

[wojtek-t]

That is P1 flake - yes we should. Adding.

[k8s-github-robot]

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

[k8s-bot]

GCE e2e build/test passed for commit 4c56b8c.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-github-robot]

Automatic merge from submit-queue