Add AppArmor feature gate #31473
Merged
Add AppArmor feature gate #31473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timstclair
added
the
do-not-merge
k8s-github-robot
added
size/S
|
lgtm, thanks |
|
I think we might need some more discussion around moving to beta. I'll update this to alpha for now, and assuming this merges first update the beta PR to bump this file as well. |
timstclair
added
release-note-none
|
Changed to alpha (still enabled by default). Removed |
j3ffml
added
the
lgtm
|
GCE e2e build/test passed for commit 9bde6f0. |
19 tasks
|
@pwittrock @timstclair Hi, I wanted to clarify does this fix a bug and why it should be in 1.4? Thanks |
apelisse
added
the
do-not-merge
apelisse
removed
the
do-not-merge
|
Thanks @jlowdermilk , makes sense to me :-) |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 9bde6f0. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to disable AppArmor via a feature gate. This PR treats AppArmor as Beta, and thus depends on #31471 (I will remove
do-not-mergeonce that merges).Note that disabling AppArmor means that pods with AppArmor annotations will be rejected in validation. It does not mean that the components act as though AppArmor was never implemented. This is by design, because we want to make it difficult to accidentally run a Pod with an AppArmor annotation without AppArmor protection.
/cc @dchen1107
This change is