-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part 1] Implementation of equivalence pod #31605
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,132 @@ | ||
/* | ||
Copyright 2016 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package scheduler | ||
|
||
import ( | ||
"github.com/golang/groupcache/lru" | ||
"hash/adler32" | ||
|
||
"k8s.io/kubernetes/pkg/api" | ||
hashutil "k8s.io/kubernetes/pkg/util/hash" | ||
"k8s.io/kubernetes/plugin/pkg/scheduler/algorithm" | ||
"sync" | ||
) | ||
|
||
// TODO(harryz) figure out the right number for this, 4096 may be too big | ||
const maxCacheEntries = 4096 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 4096 by default might be to many (e.g. in small clusters). Can you please add a TODO to figure out what this value should be. |
||
|
||
type HostPredicate struct { | ||
Fit bool | ||
FailReasons []algorithm.PredicateFailureReason | ||
} | ||
|
||
type AlgorithmCache struct { | ||
// Only consider predicates for now, priorities rely on: #31606 | ||
predicatesCache *lru.Cache | ||
} | ||
|
||
func newAlgorithmCache() AlgorithmCache { | ||
return AlgorithmCache{ | ||
predicatesCache: lru.New(maxCacheEntries), | ||
} | ||
} | ||
|
||
// Store a map of predicate cache with maxsize | ||
type EquivalenceCache struct { | ||
sync.RWMutex | ||
getEquivalencePod algorithm.GetEquivalencePodFunc | ||
algorithmCache map[string]AlgorithmCache | ||
} | ||
|
||
func NewEquivalenceCache(getEquivalencePodFunc algorithm.GetEquivalencePodFunc) *EquivalenceCache { | ||
return &EquivalenceCache{ | ||
getEquivalencePod: getEquivalencePodFunc, | ||
algorithmCache: make(map[string]AlgorithmCache), | ||
} | ||
} | ||
|
||
// addPodPredicate adds pod predicate for equivalence class | ||
func (ec *EquivalenceCache) addPodPredicate(podKey uint64, nodeName string, fit bool, failReasons []algorithm.PredicateFailureReason) { | ||
if _, exist := ec.algorithmCache[nodeName]; !exist { | ||
ec.algorithmCache[nodeName] = newAlgorithmCache() | ||
} | ||
ec.algorithmCache[nodeName].predicatesCache.Add(podKey, HostPredicate{Fit: fit, FailReasons: failReasons}) | ||
} | ||
|
||
// AddPodPredicatesCache cache pod predicate for equivalence class | ||
func (ec *EquivalenceCache) AddPodPredicatesCache(pod *api.Pod, fitNodeList []*api.Node, failedPredicates *FailedPredicateMap) { | ||
equivalenceHash := ec.hashEquivalencePod(pod) | ||
|
||
for _, fitNode := range fitNodeList { | ||
ec.addPodPredicate(equivalenceHash, fitNode.Name, true, nil) | ||
} | ||
for failNodeName, failReasons := range *failedPredicates { | ||
ec.addPodPredicate(equivalenceHash, failNodeName, false, failReasons) | ||
} | ||
} | ||
|
||
// GetCachedPredicates gets cached predicates for equivalence class | ||
func (ec *EquivalenceCache) GetCachedPredicates(pod *api.Pod, nodes []*api.Node) ([]*api.Node, FailedPredicateMap, []*api.Node) { | ||
fitNodeList := []*api.Node{} | ||
failedPredicates := FailedPredicateMap{} | ||
noCacheNodeList := []*api.Node{} | ||
equivalenceHash := ec.hashEquivalencePod(pod) | ||
for _, node := range nodes { | ||
findCache := false | ||
if algorithmCache, exist := ec.algorithmCache[node.Name]; exist { | ||
if cachePredicate, exist := algorithmCache.predicatesCache.Get(equivalenceHash); exist { | ||
hostPredicate := cachePredicate.(HostPredicate) | ||
if hostPredicate.Fit { | ||
fitNodeList = append(fitNodeList, node) | ||
} else { | ||
failedPredicates[node.Name] = hostPredicate.FailReasons | ||
} | ||
findCache = true | ||
} | ||
} | ||
if !findCache { | ||
noCacheNodeList = append(noCacheNodeList, node) | ||
} | ||
} | ||
return fitNodeList, failedPredicates, noCacheNodeList | ||
} | ||
|
||
// SendInvalidAlgorithmCacheReq marks AlgorithmCache item as invalid | ||
func (ec *EquivalenceCache) SendInvalidAlgorithmCacheReq(nodeName string) { | ||
ec.Lock() | ||
defer ec.Unlock() | ||
// clear the cache of this node | ||
delete(ec.algorithmCache, nodeName) | ||
} | ||
|
||
// SendClearAllCacheReq marks all cached item as invalid | ||
func (ec *EquivalenceCache) SendClearAllCacheReq() { | ||
ec.Lock() | ||
defer ec.Unlock() | ||
// clear cache of all nodes | ||
for nodeName := range ec.algorithmCache { | ||
delete(ec.algorithmCache, nodeName) | ||
} | ||
} | ||
|
||
// hashEquivalencePod returns the hash of equivalence pod. | ||
func (ec *EquivalenceCache) hashEquivalencePod(pod *api.Pod) uint64 { | ||
equivalencePod := ec.getEquivalencePod(pod) | ||
hash := adler32.New() | ||
hashutil.DeepHashObject(hash, equivalencePod) | ||
return uint64(hash.Sum32()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I wrote in the previous PR - this is not enough for the pod to actually be equivalent to the other one.
We should probably open an issue for this particular problem and discuss it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick note:
namespace
labels
some annotations (PodAffinity, and others?)
How to enforce that when someone will add a new predicate/priority this will be mirrored here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wojtek-t Issue fired: #32024