Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kubeletConfiguration field on Kubelet struct a value type #31660

Merged
merged 1 commit into from
Aug 30, 2016
Merged

Make kubeletConfiguration field on Kubelet struct a value type #31660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/kubelet/kubelet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ type Option func(*Kubelet)

// bootstrapping interface for kubelet, targets the initialization protocol
type KubeletBootstrap interface {
GetConfiguration() *componentconfig.KubeletConfiguration
GetConfiguration() componentconfig.KubeletConfiguration
BirthCry()
StartGarbageCollection()
ListenAndServe(address net.IP, port uint, tlsOptions *server.TLSOptions, auth server.AuthInterface, enableDebuggingHandlers bool)
Expand Down Expand Up @@ -745,7 +745,7 @@ func NewMainKubelet(kubeCfg *componentconfig.KubeletConfiguration, kubeDeps *Kub

// Finally, put the most recent version of the config on the Kubelet, so
// people can see how it was configured.
klet.kubeletConfiguration = kubeCfg
klet.kubeletConfiguration = *kubeCfg
return klet, nil
}

Expand All @@ -759,7 +759,7 @@ type nodeLister interface {

// Kubelet is the main kubelet implementation.
type Kubelet struct {
kubeletConfiguration *componentconfig.KubeletConfiguration
kubeletConfiguration componentconfig.KubeletConfiguration

hostname string
nodeName string
Expand Down Expand Up @@ -3043,7 +3043,7 @@ func (kl *Kubelet) PortForward(podFullName string, podUID types.UID, port uint16
}

// GetConfiguration returns the KubeletConfiguration used to configure the kubelet.
func (kl *Kubelet) GetConfiguration() *componentconfig.KubeletConfiguration {
func (kl *Kubelet) GetConfiguration() componentconfig.KubeletConfiguration {
return kl.kubeletConfiguration
}

Expand Down