Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change sourcesSeenLock to sync.RWMutex #31761

Merged
merged 1 commit into from
Sep 6, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/kubelet/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ type podStorage struct {
updates chan<- kubetypes.PodUpdate

// contains the set of all sources that have sent at least one SET
sourcesSeenLock sync.Mutex
sourcesSeenLock sync.RWMutex
sourcesSeen sets.String

// the EventRecorder to use
Expand Down Expand Up @@ -314,8 +314,8 @@ func (s *podStorage) markSourceSet(source string) {
}

func (s *podStorage) seenSources(sources ...string) bool {
s.sourcesSeenLock.Lock()
defer s.sourcesSeenLock.Unlock()
s.sourcesSeenLock.RLock()
defer s.sourcesSeenLock.RUnlock()
return s.sourcesSeen.HasAll(sources...)
}

Expand Down