Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeController listing nodes from apiserver cache #32081

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Sep 5, 2016

Ref #31981

This is addressing this particular failure:
#31981 (comment)


This change is Reviewable

@wojtek-t wojtek-t added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 5, 2016
@wojtek-t wojtek-t added this to the v1.4 milestone Sep 5, 2016
@gmarek gmarek added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2016
@wojtek-t wojtek-t force-pushed the list_from_apiserver_in_nodecontroller branch from d600b35 to b69d516 Compare September 5, 2016 14:53
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2016
@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2016
@wojtek-t
Copy link
Member Author

wojtek-t commented Sep 5, 2016

Fixed gofmt.

@k8s-bot
Copy link

k8s-bot commented Sep 5, 2016

GCE e2e build/test passed for commit b69d516.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 5, 2016

GCE e2e build/test passed for commit b69d516.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit de954c0 into kubernetes:master Sep 5, 2016
@wojtek-t wojtek-t deleted the list_from_apiserver_in_nodecontroller branch September 16, 2016 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants