Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add group prefix matching for kubectl usage #32140

Merged
merged 1 commit into from
Sep 10, 2016
Merged

add group prefix matching for kubectl usage #32140

merged 1 commit into from
Sep 10, 2016
+156 −1

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 6, 2016 •
edited
Loading

Adds prefix matching for groups so that kubectl get storageclass.storage matches storageclass.storage.k8s.io.

@kubernetes/kubectl

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Sep 6, 2016
@0xmichalis
Copy link
Contributor

LGTM

1 similar comment
@fabianofranz
Copy link
Contributor

LGTM

@lavalamp
Copy link
Member

lavalamp commented Sep 6, 2016

Are you trying to get this in 1.4?

@deads2k
Copy link
Contributor Author

deads2k commented Sep 6, 2016

@lavalamp No, but I'd like the option for 1.4.1 if you're ok with it.

@lavalamp lavalamp assigned krousey and unassigned lavalamp Sep 6, 2016
@lavalamp
Copy link
Member

lavalamp commented Sep 6, 2016

sure, that seems fine.

@deads2k deads2k force-pushed the restmapper-02-match-partial-groups branch from 9aa8626 to 8eaf5ae Compare September 7, 2016 11:40
@deads2k deads2k force-pushed the restmapper-02-match-partial-groups branch from 8eaf5ae to f9b498e Compare September 7, 2016 14:32
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2016
@k8s-bot
Copy link

k8s-bot commented Sep 7, 2016

GCE e2e build/test passed for commit f9b498e.

@krousey krousey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2016
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Sep 7, 2016
@deads2k deads2k added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Sep 7, 2016
@deads2k deads2k added this to the v1.5 milestone Sep 8, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 10, 2016

GCE e2e build/test passed for commit f9b498e.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 0764aa0 into kubernetes:master Sep 10, 2016
@deads2k deads2k deleted the restmapper-02-match-partial-groups branch February 1, 2017 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krousey krousey

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@deads2k @0xmichalis @fabianofranz @lavalamp @k8s-bot @k8s-github-robot @krousey @googlebot