Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rkt: Refactor host file mounts for host network. #32148

Merged
merged 1 commit into from
Sep 10, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/pod
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ metadata:
labels:
name: nginx
spec:
initcontainers:
name: busybox
image: busybox
containers:
- name: nginx
image: nginx
Expand Down
52 changes: 35 additions & 17 deletions pkg/kubelet/rkt/rkt.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ const (

// defaultRequestTimeout is the default timeout of rkt requests.
defaultRequestTimeout = 2 * time.Minute

etcHostsPath = "/etc/hosts"
etcResolvConfPath = "/etc/resolv.conf"
)

// Runtime implements the Containerruntime for rkt. The implementation
Expand Down Expand Up @@ -657,27 +660,42 @@ func copyfile(src, dst string) error {

// TODO(yifan): Can make rkt handle this when '--net=host'. See https://github.com/coreos/rkt/issues/2430.
func makeHostNetworkMount(opts *kubecontainer.RunContainerOptions) (*kubecontainer.Mount, *kubecontainer.Mount, error) {
hostsPath := filepath.Join(opts.PodContainerDir, "etc-hosts")
resolvPath := filepath.Join(opts.PodContainerDir, "etc-resolv-conf")

if err := copyfile("/etc/hosts", hostsPath); err != nil {
return nil, nil, err
}
if err := copyfile("/etc/resolv.conf", resolvPath); err != nil {
return nil, nil, err
mountHosts, mountResolvConf := true, true
for _, mnt := range opts.Mounts {
switch mnt.ContainerPath {
case etcHostsPath:
mountHosts = false
case etcResolvConfPath:
mountResolvConf = false
}
}

hostsMount := kubecontainer.Mount{
Name: "kubernetes-hostnetwork-hosts-conf",
ContainerPath: "/etc/hosts",
HostPath: hostsPath,
var hostsMount, resolvMount kubecontainer.Mount
if mountHosts {
hostsPath := filepath.Join(opts.PodContainerDir, "etc-hosts")
if err := copyfile(etcHostsPath, hostsPath); err != nil {
return nil, nil, err
}
hostsMount = kubecontainer.Mount{
Name: "kubernetes-hostnetwork-hosts-conf",
ContainerPath: etcHostsPath,
HostPath: hostsPath,
}
opts.Mounts = append(opts.Mounts, hostsMount)
}
resolvMount := kubecontainer.Mount{
Name: "kubernetes-hostnetwork-resolv-conf",
ContainerPath: "/etc/resolv.conf",
HostPath: resolvPath,

if mountResolvConf {
resolvPath := filepath.Join(opts.PodContainerDir, "etc-resolv-conf")
if err := copyfile(etcResolvConfPath, resolvPath); err != nil {
return nil, nil, err
}
resolvMount = kubecontainer.Mount{
Name: "kubernetes-hostnetwork-resolv-conf",
ContainerPath: etcResolvConfPath,
HostPath: resolvPath,
}
opts.Mounts = append(opts.Mounts, resolvMount)
}
opts.Mounts = append(opts.Mounts, hostsMount, resolvMount)
return &hostsMount, &resolvMount, nil
}

Expand Down