Split dns healthcheck into two different urls #32406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/L
|
GCE e2e build/test passed for commit 952bcf6. |
k8s-github-robot
added
needs-rebase
| - -port=8080 | ||
| - -quiet | ||
| command: ["/bin/sh","-c"] | ||
| args: ["/exechealthz -cmd='nslookup kubernetes.default.svc.__PILLAR__DNS__DOMAIN__ 127.0.0.1 >/dev/null' -port=8082 -quiet & /exechealthz -cmd='nslookup kubernetes.default.svc.__PILLAR__DNS__DOMAIN__ 127.0.0.1:10053 >/dev/null' -port=8080 -quiet"] |
There was a problem hiding this comment.
We should not do this - if one of them dies it will not get restarted
We should either run two whole containers or make one container able to handle both (as you suggested)
|
Now that the exec-healthz is in, ping me when this is ready |
|
Thanks for get that in. Sure, no problem. |
k8s-github-robot
added
the
needs-rebase
MrHohn
force-pushed
the
kubedns-healthz
branch
from
952bcf6
to
d17cd1a
Compare
MrHohn
changed the title
k8s-github-robot
removed
the
needs-rebase
|
This new commit now using the latest version exec-healthz to split the health check into two separate urls. Also all related dns yaml files are kept in sync.
|
thockin
added
lgtm
|
LGTM |
|
Build finished. 691 tests run, 200 skipped, 0 failed. |
|
@k8s-bot test this please, issue #IGNORE |
|
Jenkins verification failed for commit d17cd1a. Full PR test history. The magic incantation to run this job again is |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Jenkins GKE smoke e2e failed for commit d17cd1a. Full PR test history. The magic incantation to run this job again is |
|
Automatic merge from submit-queue |
euank
added a commit
to euank/kubernetes
that referenced
this pull request
Sep 29, 2016
This bug was inadvertently introduced in kubernetes#32406. The longer term plan (shouldn't be too much longer) is to remove this file entirely and rely on the `gci-trusty` version of it, but to stop some bleeding and allow our jenkins using kube-up + coreos to work, we should merge this fix until we have the more complete solution.
k8s-github-robot
pushed a commit
that referenced
this pull request
Sep 30, 2016
Automatic merge from submit-queue gce/coreos: Fix dnsmasq image name This bug was inadvertently introduced in #32406. The longer term plan (shouldn't be too much longer) is to remove this file entirely and rely on the `gci-trusty` version of it, but to stop some bleeding and allow our jenkins using kube-up + coreos to work, we should merge this fix until we have the more complete solution. cc @MrHohn @yifan-gu @thockin
MrHohn
pushed a commit
to MrHohn/kubernetes
that referenced
this pull request
Oct 7, 2016
This bug was inadvertently introduced in kubernetes#32406. The longer term plan (shouldn't be too much longer) is to remove this file entirely and rely on the `gci-trusty` version of it, but to stop some bleeding and allow our jenkins using kube-up + coreos to work, we should merge this fix until we have the more complete solution.
This was referenced Oct 7, 2016
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 7, 2016
…32422-#32406-#33146-#33774-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of #31894 #32422 #32406 #33146 #33774 Cherry pick of #31894 #32422 #32406 #33146 #33774 on release-1.4. #31894: Support graceful termination in kube-dns #32422: Added --log-facility flag to enhance dnsmasq logging #32406: Split dns healthcheck into two different urls #33146: Tune down initialDelaySeconds for readinessProbe #33774: Bump up addon kube-dns to v20 for graceful termination
|
cherry-picked to 1.4 in #34290 removing cherry-pick candidate |
jessfraz
added
release-note
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…-of-#31894-kubernetes#32422-kubernetes#32406-kubernetes#33146-kubernetes#33774-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#31894 kubernetes#32422 kubernetes#32406 kubernetes#33146 kubernetes#33774 Cherry pick of kubernetes#31894 kubernetes#32422 kubernetes#32406 kubernetes#33146 kubernetes#33774 on release-1.4. kubernetes#31894: Support graceful termination in kube-dns kubernetes#32422: Added --log-facility flag to enhance dnsmasq logging kubernetes#32406: Split dns healthcheck into two different urls kubernetes#33146: Tune down initialDelaySeconds for readinessProbe kubernetes#33774: Bump up addon kube-dns to v20 for graceful termination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #30633.
This new kube-dns pod template creates two exechealthz processes listen on two different ports for kubedns and dnsmasq correspondingly.@thockin @girishkalele
This change is