Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local-up-cluster.sh: add SERVICE_CLUSTER_IP_RANGE as option #32921

Merged
merged 1 commit into from
Sep 27, 2016
Merged

local-up-cluster.sh: add SERVICE_CLUSTER_IP_RANGE as option #32921

merged 1 commit into from
Sep 27, 2016

Conversation

aanm
Copy link
Contributor

@aanm aanm commented Sep 16, 2016 •
edited by k8s-oncall
Loading

Allows the user the use an environment variable to specify the SERVICE_CLUSTER_IP_RANGE without modifying the hack/local-up-cluster.sh script.

Signed-off-by: André Martins aanm90@gmail.com

This change is Reviewable

@aanm
local-up-cluster.sh: add SERVICE_CLUSTER_IP_RANGE as option
f225d4a 
Signed-off-by: André Martins <aanm90@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line.

Regular contributors should join the org to skip this step.

While we transition away from the Jenkins GitHub PR Builder plugin, "ok to test" commenters will need to be on the admin list defined in this file.

@aanm
Copy link
Contributor Author

aanm commented Sep 16, 2016

Is it too late to merge this into 1.3.8-beta.0?

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Sep 16, 2016
@aanm
Copy link
Contributor Author

aanm commented Sep 22, 2016

@zmerlynn I think you have to change the labels in order for the @googlebot to catch it up

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2016
@zmerlynn
Copy link
Member

@aanm: Fixed, sorry, I thought the munger caught approval -> auto-LGTM by now.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Sep 26, 2016
@zmerlynn zmerlynn added release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 26, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI Kubemark GCE e2e failed for commit f225d4a. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark gci e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 98a4a82 into kubernetes:master Sep 27, 2016
@aanm aanm deleted the adding-service-ip-range-as-option branch October 16, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerlynn zmerlynn zmerlynn approved these changes

Assignees

@zmerlynn zmerlynn

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aanm @k8s-ci-robot @zmerlynn @k8s-github-robot @googlebot @wojtek-t