Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

federation e2e tests failing consistently with gce/util.sh: line 1192: local: `replica-pd=jenkins-us-central1-b-master-pd': not a valid identifier #32997

Closed
ghost opened this issue Sep 18, 2016 · 4 comments · Fixed by #33039
Closed

federation e2e tests failing consistently with gce/util.sh: line 1192: local: `replica-pd=jenkins-us-central1-b-master-pd': not a valid identifier #32997

ghost opened this issue Sep 18, 2016 · 4 comments · Fixed by #33039
Assignees
@madhusudancs
Labels
area/test-infra priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.4

Comments

@ghost
Copy link

ghost commented Sep 18, 2016

./hack/e2e-internal/.../cluster/gce/util.sh: line 1192: local: `replica-pd=jenkins-us-central1-b-master-pd': not a valid identifier

@colhom @madhusudancs FYI - this looks related to your recent work? I don't see any obvious PR to blame, but I seem to remember you guys touching this part of the code recently?

BTW, I deleted a bunch of leaked resources in the relevant test project on Friday (9/16), assuming that the test scripts would re-create whatever they needed. It's possible (but unlikely) that this has anything to do with that.
@ghost ghost added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/cluster-federation release-blocker labels Sep 18, 2016
@ghost ghost added this to the v1.4 milestone Sep 18, 2016
@ghost ghost removed the area/node-e2e label Sep 18, 2016
@ghost ghost assigned madhusudancs Sep 18, 2016
@ghost
Copy link
Author

ghost commented Sep 19, 2016

@colhom Here are some example logs to aid debugging:

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-e2e-gce-federation/4332

@colhom
Copy link

colhom commented Sep 19, 2016

@quinton-hoole I believe this to be the source of dysfunction:

ERROR: (gcloud.compute.disks.create) Some requests did not succeed:
 - The resource 'projects/k8s-jkns-e2e-gce-federation/zones/us-central1-a/disks/jenkins-us-central1-a-master-pd' already exists

Which is turn caused by what you found, which causes the disk to not be cleaned up ahead of time:

./hack/e2e-internal/.../cluster/gce/util.sh: line 1192: local: `replica-pd=jenkins-us-central1-b-master-pd': not a valid identifier

kubernetes/cluster/gce/util.sh

Line 1194 in 87b4078

local -r replica-pd="${REPLICA_NAME:-${MASTER_NAME}}-pd"

You can try this out in your local shell:

[chom@hompad-work kubernetes]$ REPLICA_NAME="replica-pd=jenkins-us-central1-a-master"
[chom@hompad-work kubernetes]$ function set-replica-name { local -r replica-pd="${REPLICA_NAME:-${MASTER_NAME}}-pd"; }
[chom@hompad-work kubernetes]$ set-replica-name 
-bash: local: `replica-pd=replica-pd=jenkins-us-central1-a-master-pd': not a valid identifier

git blames leads us to this recent commit: 529818c9

\cc the author @jszczepkowski

The root problem is unfortunatley very annoying: this is how bash tells you that variable names (in this case, $replica-pd) cannot contain dashes!

colhom pushed a commit to colhom/kubernetes that referenced this issue Sep 19, 2016
gce/util: $replica-pd --> $replica_pd
acd7f50 
fixes kubernetes#32997
@colhom colhom mentioned this issue Sep 19, 2016
Merged
@colhom
Copy link

colhom commented Sep 19, 2016

@quinton-hoole fix is up in #33039

@ghost
Copy link
Author

ghost commented Sep 19, 2016

Awesome @colhom many thanks. I'll make sure it gets merged ASAP.

@ghost ghost added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker labels Sep 19, 2016
@pwittrock pwittrock added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 20, 2016
k8s-github-robot pushed a commit that referenced this issue Sep 21, 2016
Merge pull request #33039 from colhom/fix-bad-var-name-gce
01dd125 
Automatic merge from submit-queue

gce/util: $replica-pd --> $replica_pd

\cc @quinton-hoole @madhusudancs 

fixes #32997
ixdy pushed a commit to ixdy/kubernetes that referenced this issue Oct 28, 2016
@ixdy
gce/util: $replica-pd --> $replica_pd
95f8fc0 
fixes kubernetes#32997
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this issue Dec 1, 2016
@ixdy
gce/util: $replica-pd --> $replica_pd
d6f8350 
fixes kubernetes#32997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhusudancs madhusudancs

Labels
area/test-infra priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

gce/util: $replica-pd --> $replica_pd colhom/kubernetes
4 participants
@madhusudancs @colhom @pwittrock @k8s-github-robot