gce/util: $replica-pd --> $replica_pd

[colhom]

\cc @quinton-hoole @madhusudancs

fixes #32997

---

This change is

[k8s-ci-robot]

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line.

Regular contributors should join the org to skip this step.

While we transition away from the Jenkins GitHub PR Builder plugin, "ok to test" commenters will need to be on the admin list defined in this file.

[madhusudancs]

@k8s-bot ok to test

[madhusudancs]

---

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[k8s-bot]

GCE e2e build/test passed for commit acd7f50.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-cherrypick-bot]

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

[ghost]

@k8s-bot federation gce e2e test this

[madhusudancs]

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[k8s-ci-robot]

Jenkins GCE e2e failed for commit acd7f50.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[ghost]

@k8s-bot test this issue #IGNORE

[pwittrock]

@k8s-bot unit test this issue: #32770

[pwittrock]

@madhusudancs @colhom Is this supposed to get cherrypicked into 1.4? This references a launch blocking issues for 1.4. Is that issue not launch blocking, or is this a launch blocking PR?

[madhusudancs]

@pwittrock this is not exactly a release blocker. This is in kube-down. In some small set of cases, users can hit this code path if the previous kube-up run failed to clean up resources during an earlier run correctly. I don't see it as that big of an issue, but it might look bad if the user actually hits this. I would like to get this cherry-picked, but I wouldn't hold the release. Can go in a patch release.

[pwittrock]

Does this fix #32997? Is #32997 a release blocker?

[madhusudancs]

#32997 is not a release blocker.

[madhusudancs]

@k8s-bot unit test this issue: #IGNORE

[k8s-github-robot]

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue

[janetkuo]

@madhusudancs @pwittrock Do we need to cherrypick this? $replica_pd does not exist in 1.4 code https://github.com/kubernetes/kubernetes/blob/release-1.4/cluster/gce/util.sh#L1191-L1198

[madhusudancs]

@janetkuo Talked to @pwittrock about this. If the original code isn't in v1.4 we don't have to cherry pick this.

[ghost]

Yes, I can confirm that the bug that this PR fixes was never cherrypicked into v1.4 branch, so no need for this fix to be cherrypicked either.