Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readability: error string #33

Closed
ukai opened this issue Jun 9, 2014 · 1 comment
Closed

readability: error string #33

ukai opened this issue Jun 9, 2014 · 1 comment

Comments

@ukai
Copy link
Contributor

ukai commented Jun 9, 2014

Error strings should not be capitalized (unless beginning with proper nouns or acronyms).
https://code.google.com/p/go-wiki/wiki/CodeReviewComments#Error_Strings

e.g.
$ grep 'fmt.Errorf("[A-Z]' pkg//.go
@brendandburns
Copy link
Contributor

Closed by #102

@atishn atishn mentioned this issue Oct 30, 2014
Closed
feiskyer added a commit to feiskyer/kubernetes that referenced this issue Nov 6, 2015
@feiskyer
Merge pull request kubernetes#33 from hyperhq/shippable
0f9b173 
Update shippable.yml
vishh pushed a commit to vishh/kubernetes that referenced this issue Apr 6, 2016
@monnand
Merge pull request kubernetes#33 from monnand/travis-ci
215627d 
Travis ci
mbruzek added a commit to mbruzek/kubernetes that referenced this issue Sep 22, 2016
@mbruzek
Merge pull request kubernetes#33 from chuckbutler/chown-patch
225bccb 
Replace relative path with absolute path in chown command
xingzhou pushed a commit to xingzhou/kubernetes that referenced this issue Dec 15, 2016
@mattfarina
Merge pull request kubernetes#33 from michelleN/sig-apps
473302e 
sig-apps: update agenda for aug 3
iaguis pushed a commit to kinvolk/kubernetes that referenced this issue Feb 6, 2018
@aaronlevy
Merge pull request kubernetes#33 from projectcalico/core-hyperkube-v1…
31d1252 
….2.2-cni

Coreos hyperkube v1.2.2 cni
andyzhangx added a commit to andyzhangx/kubernetes that referenced this issue Mar 16, 2018
@andyzhangx @JiangtianLi
merge#975d0a4 (part of PR#61047:subpath security fix) (kubernetes#33)
a36d59d 
remove makeLink func redeclaration
whypro pushed a commit to whypro/kubernetes that referenced this issue May 24, 2018
@cofyc
Merge pull request kubernetes#33 from qbox/fix_cpuovercommit_1.9
55e1178 
fix type mismatch
@pascalgn pascalgn mentioned this issue Dec 6, 2018
Closed
@vigneshsolution vigneshsolution mentioned this issue Aug 2, 2020
Closed
This was referenced Oct 1, 2020
Closed
Closed
Closed
@lfdominguez lfdominguez mentioned this issue Apr 13, 2021
Closed
linxiulei pushed a commit to linxiulei/kubernetes that referenced this issue Jan 18, 2024
@Random-Liu
Merge pull request kubernetes#33 from AdoHe/journald
077dafc 
add journal support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ukai @brendandburns