Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better AWS logging around volumes #33067

Merged
merged 1 commit into from
Sep 28, 2016
Merged

Better AWS logging around volumes #33067

merged 1 commit into from
Sep 28, 2016

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Sep 20, 2016 •
edited by k8s-oncall
Loading

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Sep 20, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 50f55689553abd93cf12e945f37b875368ae7e22.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@errordeveloper
Copy link
Member

Are you looking to improve all of the log message, and not just the storage stuff?

@justinsb
Copy link
Member Author

@errordeveloper all improvements are welcome, but this PR is just about aws storage :-)

@justinsb justinsb changed the title WIP: Better AWS logging Better AWS logging around volumes Sep 27, 2016
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2016
@k8s-github-robot k8s-github-robot mentioned this pull request Sep 27, 2016
Closed
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 310423a. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@justinsb
Copy link
Member Author

@k8s-bot gke e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 310423a. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@errordeveloper
Copy link
Member

Yeah, I was hinting at whearher the title need to reflect the fact, I can
see you have updated it now.

On Tue, 27 Sep 2016, 17:02 k8s-ci-robot, notifications@github.com wrote:

Jenkins GCI GCE e2e failed
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/33067/kubernetes-pull-build-test-gci-e2e-gce/298/
for commit 310423a
310423a.
Full PR test history http://pr-test.k8s.io/33067.

The magic incantation to run this job again is @k8s-bot gci gce e2e test
this. Please help us cut down flakes by linking to an open flake issue
https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open
when you hit one in your PR.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33067 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPWS6R2mrl5kQ1vDJDzWevRbdEM80tEks5quT4AgaJpZM4KBPSs
.

@jingxu97 jingxu97 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2016
@jingxu97
Copy link
Contributor

LGTM Thanks!

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Sep 27, 2016
@justinsb justinsb added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Sep 28, 2016
@justinsb
Copy link
Member Author

@k8s-bot gci gce e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit c20965c into kubernetes:master Sep 28, 2016
@k8s-github-robot k8s-github-robot mentioned this pull request Oct 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jingxu97 jingxu97

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@justinsb @k8s-ci-robot @errordeveloper @jingxu97 @k8s-github-robot @googlebot @wojtek-t