Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set a service nodeport #33319

Merged
merged 4 commits into from
Oct 5, 2016
Merged

Add option to set a service nodeport #33319

merged 4 commits into from
Oct 5, 2016

Commits on Oct 4, 2016

  1. Add option to set a service nodeport 

    This patch adds the option to set a nodeport when creating a NodePort
service. In case of a port allocation error due to a specified port
being out of the valid range, the error now includes the valid
range. If a `--node-port` value is not specified, it defaults to zero, in
which case the allocator will default to its current behavior of
assigning an available port.

This patch also adds a new helper function in `cmd/util/helpers.go` to
retrieve `Int32` cobra flags.

**Example**
```
$ kubectl create service nodeport mynodeport --tcp=8080:7777 --node-port=1
The Service "mynodeport" is invalid: spec.ports[0].nodePort: Invalid
value: 1: provided port is not in the valid range. Valid ports range
from 30000-32767

$ kubectl create service nodeport mynodeport --tcp=8080:7777 --node-port=30000
service "mynodeport" created

$ oc describe service mynodeport
Name:                   mynodeport
Namespace:              default
Labels:                 app=mynodeport
Selector:               app=mynodeport
Type:                   NodePort
IP:                     172.30.81.254
Port:                   8080-7777       8080/TCP
NodePort:               8080-7777       30000/TCP
Endpoints:              <none>
Session Affinity:       None
No events.
```
    @juanvallejo
    juanvallejo committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    6b83f89 View commit details
    Browse the repository at this point in the history

  2. make portallocator.ErrNotInRange a type

    @juanvallejo
    juanvallejo committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    cfbdcec View commit details
    Browse the repository at this point in the history

  3. update known flags

    @juanvallejo
    juanvallejo committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    395f6fd View commit details
    Browse the repository at this point in the history

  4. remove unused GetFlagInt32 func

    @juanvallejo
    juanvallejo committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    7d1461b View commit details
    Browse the repository at this point in the history