Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for daemonset pod affinity #33523

Closed
wants to merge 2 commits into from
Closed

Add e2e test for daemonset pod affinity #33523

wants to merge 2 commits into from

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Sep 27, 2016 •
edited

Add e2e test for #31136. Includes commits from #31136 and #33451, will linearize the history if/when these PRs are merged.

EDIT: #33451 got merged so I updated this PR.

This change is Reviewable

@ivan4th ivan4th mentioned this pull request Sep 27, 2016
Closed
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Sep 27, 2016
@ixdy ixdy assigned davidopp and unassigned fejta Sep 27, 2016
@ivan4th
Copy link
Contributor Author

ivan4th commented Oct 4, 2016

@k8s-bot gke e2e test this

@ivan4th
Copy link
Contributor Author

ivan4th commented Oct 4, 2016

@k8s-bot gci gce e2e test this

flake: #34014

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2016
@ivan4th ivan4th force-pushed the add-e2e-test-for-daemonset-pod-affinity branch from b2d55ce to 281c0bc Compare October 7, 2016 14:28
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 7, 2016
@ivan4th ivan4th force-pushed the add-e2e-test-for-daemonset-pod-affinity branch from 281c0bc to ba437c0 Compare October 13, 2016 08:11
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2016
@ivan4th
Copy link
Contributor Author

ivan4th commented Nov 7, 2016

I hope it'll be possible to merge this in 1.6. So let's keep it open for now

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 10, 2016
@apelisse apelisse removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 11, 2016
@k8s-github-robot
Copy link

This PR hasn't been active in 30 days. It will be closed in 59 days (Feb 5, 2017).

cc @davidopp @ivan4th

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

@ivan4th ivan4th force-pushed the add-e2e-test-for-daemonset-pod-affinity branch from ba437c0 to 266fbdf Compare December 8, 2016 13:23
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 8, 2016
@ivan4th ivan4th force-pushed the add-e2e-test-for-daemonset-pod-affinity branch from 266fbdf to a9647ed Compare December 12, 2016 17:44
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2016
@k8s-github-robot
Copy link

@ivan4th PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @bprashanth @ixdy
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot assigned ixdy and bprashanth and unassigned davidopp and ixdy Jan 30, 2017
@ixdy ixdy removed their assignment Jan 31, 2017
@krousey
Copy link
Contributor

krousey commented Jul 19, 2017

/unassign

@k8s-github-robot
Copy link

Adding do-not-merge/release-note-label-needed because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-action-required", "release-note-experimental" or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 30, 2017
@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed keep-open labels Dec 15, 2017
@cblecker
Copy link
Member

This PR doesn't appear to be active, and there is no criteria for moving it forward.
Removing lifecycle/frozen status.

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 10, 2018
@cblecker
Copy link
Member

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed cla: yes labels Mar 15, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 15, 2018
@cblecker cblecker closed this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

@kow3ns kow3ns

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet