[low priority] [idea] Match() cache.

[jayunit100]

Problem:

Match is using alot of CPU in issues like #31795 .

Solution:

Disclaimer: I havent investigated wether or not redundant calls to match are happening, but i suspect if you had 1000 nodes, and say 100 pods per node, and were scanning labels, you could have alot of string comparison churn if the pods were identical or similar. I'd need to watch the match ops @ scale to really confirm if theres any redundancy.

Anyway, Here's a possibility for optimizing Match() performance. Could be improved via xref #33572 . I'll write some tests to confirm its cache speeds things up (At least in the obvious case scenarios). The hard part will be determining in the "real world" wether or not we have a high likliehood of bursts of identical Match operations. cc @kubernetes/sig-scheduling

---

This change is

[jayunit100]

note this is largely untested, will verify it some more later.

[k8s-ci-robot]

Jenkins GCI GKE smoke e2e failed for commit fadf5d0. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[jayunit100]

@k8s-bot gci gke e2e test this issue #33175.

[jayunit100]

this is a convenience interface update, that allows lookups in Match cache so that any Labels support hashing. should generally work since there is a String rep, but havent tested it under all conditions

[k8s-ci-robot]

Jenkins unit/integration failed for commit ce499ed. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[k8s-ci-robot]

Jenkins verification failed for commit ce499ed. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[k8s-ci-robot]

Jenkins GCI GCE e2e failed for commit ce499ed. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[k8s-ci-robot]

Jenkins GKE smoke e2e failed for commit ce499ed. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[jayunit100]

I think for now this is a microoptimization: the Has function implementations i looked at i think are constant time , no loops. If we are going to have more complex Has implementations for label sets etc, in the future this type of cache could help. will close [temporarily at least]