Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sysctl psp tests #33821

Merged
merged 4 commits into from
Oct 3, 2016
Merged

Improve sysctl psp tests #33821

merged 4 commits into from
Oct 3, 2016

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Sep 30, 2016 •
edited by k8s-oncall

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

This change is Reviewable

@sttts sttts added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 30, 2016
@sttts sttts assigned ncdc and pweil- Sep 30, 2016
@sttts sttts changed the title Various sysctl unit test fixes Various sysctl psp unit test fixes Sep 30, 2016
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Sep 30, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 7c9aa4cc683e76755d1085c4f12c234f670437a9. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

mdshuai
mdshuai reviewed Sep 30, 2016
View reviewed changes
pkg/api/helpers.go
@@ -577,7 +577,7 @@ func SysctlsFromPodAnnotation(annotation string) ([]Sysctl, error) {
sysctls := make([]Sysctl, len(kvs))
for i, kv := range kvs {
cs := strings.Split(kv, "=")
if len(cs) != 2 {
if len(cs) != 2 || len(cs[0]) == 0 {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does cs[1] can be empty ?
Actually when cs[0] is empty or invalid name format, it can be validated now but cs[1] can't. http://pastebin.test.redhat.com/417014

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty string is a completely valid sysctl value. Unfortunately, we hardly know anything about those values.

During alpha (when we use annotations, we deliberately assume that at least = and , are no valid characters in values.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 8738303. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@sttts
Copy link
Contributor Author

sttts commented Sep 30, 2016

@k8s-bot gci gke e2e test this

@sttts
Copy link
Contributor Author

sttts commented Sep 30, 2016

@k8s-bot gke e2e test this

@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Sep 30, 2016
@sttts sttts changed the title Various sysctl psp unit test fixes Improve sysctl psp tests Sep 30, 2016
@sttts sttts added area/test and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/test labels Sep 30, 2016
@sttts
Copy link
Contributor Author

sttts commented Sep 30, 2016

@k8s-bot gke e2e test this

1 similar comment
@sttts
Copy link
Contributor Author

sttts commented Sep 30, 2016

@k8s-bot gke e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit e6acc08. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@sttts
Copy link
Contributor Author

sttts commented Sep 30, 2016

@k8s-bot gke e2e test this

@pweil-
Copy link
Contributor

pweil- commented Oct 3, 2016

lgtm

@ncdc ncdc added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3933ddb into kubernetes:master Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdshuai mdshuai mdshuai left review comments

Assignees

@ncdc ncdc

@pweil- pweil-

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sttts @k8s-ci-robot @pweil- @k8s-github-robot @mdshuai @ncdc @googlebot