-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not probe so aggressively which may lead to unnecessary restarts #33859
Do not probe so aggressively which may lead to unnecessary restarts #33859
Conversation
Jenkins unit/integration failed for commit b0fb446. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE e2e failed for commit b0fb446. Full PR test history. The magic incantation to run this job again is |
Jenkins GCI GKE smoke e2e failed for commit b0fb446. Full PR test history. The magic incantation to run this job again is |
Jenkins GKE smoke e2e failed for commit b0fb446. Full PR test history. The magic incantation to run this job again is |
Jenkins GCI GCE e2e failed for commit b0fb446. Full PR test history. The magic incantation to run this job again is |
Those were copied from @mikedanese's Jsonnet definitions in Kubernetes On Fri, 30 Sep 2016, 21:53 k8s-ci-robot, notifications@github.com wrote:
|
You should just add a failure threshold. Do we know if this will even help? |
…rt unless really necessary
4edd40f
to
6027477
Compare
Jenkins Kubemark GCE e2e failed for commit 6027477. Full PR test history. The magic incantation to run this job again is |
@errordeveloper Does this look good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
@errordeveloper @mikedanese PTAL
I came across a case where etcd restarted about 5-10 times because the load was very high on the machine.
The load seems to have lead to that the
etcd
container occasionally didn't respond to the probe, which caused many restart and made the whole thing even worse.Maybe we should remove the etcd probe totally? I don't know, what do you think?
This is at least a try to loosen the limits here...
This change is