specify flags to test-integration #33952

deads2k · 2016-10-03T18:04:10Z

Allows a specific test to be run in test-integration: hack/test-integration.sh auth -test.run=TestKindAuthorization

@eparis I don't know how good or bad my bash is.

This change is

k8s-ci-robot · 2016-10-03T18:28:25Z

Jenkins GCE e2e failed for commit 08d41ed. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

eparis · 2016-10-03T18:36:10Z

I doubt the failure on gce e2e is this PRs:

�[0;33mAttempt 5 failed to create firewall rule e2e-gce-agent-pr-29-0-minion-all. Retrying.�[0m
ERROR: (gcloud.compute.firewall-rules.create) Some requests did not succeed:
 - Quota 'FIREWALLS' exceeded. Limit: 200.0

k8s-ci-robot · 2016-10-03T18:43:26Z

Jenkins GCI GCE e2e failed for commit 08d41ed. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

eparis · 2016-10-03T18:23:11Z

hack/make-rules/test-integration.sh

@@ -90,8 +90,17 @@ if [[ -n "${KUBE_TEST_ARGS}" ]]; then
  runTests v1
 fi

+# Pass arguments that with "-" and move them to goflags.


missing word: begining?

eparis · 2016-10-03T19:26:10Z

hack/make-rules/test-integration.sh

+what_flags=""
+for arg in "$@"; do
+  if [[ "${arg}" == -* ]]; then
+    what_flags="${what_flags} \"${arg}\""


what_flags=() for arg in "$@"; do if [[ "${arg}" == -* ]]; then what_flags+=("${arg}") fi done echo "${what_flags[@]}"

echo "${what_flags[@]}"

Where do I do this echo? Just informational or something?

what_flags=()
for arg in "$@"; do
if [[ "${arg}" == -* ]]; then
what_flags+=("${arg}")
fi
done

echo "${what_flags[@]}"

Didn't work. It dropped the second flag, so hack/test-integration.sh auth -test.run=TestKindAuthorization -v didn't give me the -v.

deads2k · 2016-10-04T16:41:11Z

@stevekuznetsov can you help with this bash?

stevekuznetsov · 2016-10-04T16:55:07Z

hack/make-rules/test-integration.sh

@@ -62,7 +62,7 @@ runTests() {
  # TODO: Re-enable race detection when we switch to a thread-safe etcd client
  # KUBE_RACE="-race"
  make -C "${KUBE_ROOT}" test \
-      WHAT="$(kube::test::find_integration_test_dirs ${2-} | paste -sd' ' -)" \
+      WHAT="$(kube::test::find_integration_test_dirs ${2-} | paste -sd' ' -) ${3-} " \


We prefer ${var:-'default'} since it's not often that someone wants to pass an null var around as a meaningful value.

stevekuznetsov · 2016-10-04T16:55:47Z

hack/make-rules/test-integration.sh

@@ -90,8 +90,17 @@ if [[ -n "${KUBE_TEST_ARGS}" ]]; then
  runTests v1
 fi

+# Pass arguments that begin with "-" and move them to goflags.


You may want optparse for parsing options ... not sure attempts to do things like this are a good idea, they can get bloated quickly and have rough edges.

You may want optparse for parsing options ... not sure attempts to do things like this are a good idea, they can get bloated quickly and have rough edges.

Not for this I don't think.

stevekuznetsov · 2016-10-04T16:56:33Z

hack/make-rules/test-integration.sh

+  fi
+done
+
+
 # Convert the CSV to an array of API versions to test
 IFS=';' read -a apiVersions <<< "${KUBE_TEST_API_VERSIONS}"


I'm 99% sure this IFS reset is leaking to the rest of the script

I'm 99% sure this IFS reset is leaking to the rest of the script

preexisting

Leave it better than you found it and all that :)

stevekuznetsov · 2016-10-04T17:03:32Z

hack/make-rules/test-integration.sh

 # Convert the CSV to an array of API versions to test
 IFS=';' read -a apiVersions <<< "${KUBE_TEST_API_VERSIONS}"
 for apiVersion in "${apiVersions[@]}"; do
-  runTests "${apiVersion}" "${1-}"
+  runTests "${apiVersion}" "${1-}" "${what_flags}"


This won't work how you think it will. You're always going to have one argument to runTests that you break up later, but it will break like this:

myvar="\"-first\" \"-second=val\" \"-third 'other val'\"" ... runTests "${apiVersion}" "${1-}" "\"-first\" \"-second=val\" \"-third 'other val'\"" ^----arg0-----^ ^-arg1^ ^----------------------arg2-----------------------^ ... make ... WHAT="... \"-first\" \"-second=val\" \"-third 'other val'\"" ^--arg0--^ ^----arg1-----^ ^-arg2-^ ^arg3^ ^arg4^

What you want to do is:

make $what_flags into an array

append to the array correctly (array+=( "new item with spaces or whatever" ))

expand the array into args here runTests ... "${what_flags[@]}"

expect varargs in runTests from arg 3 onward WHAT="$( whatever ) ${@:4}"

What you want to do is:

make $what_flags into an array
append to the array correctly (array+=( "new item with spaces or whatever" ))
expand the array into args here runTests ... "${what_flags[@]}"
expect varargs in runTests from arg 3 onward WHAT="$( whatever ) ${@:4}"

Doesn't work.

deads2k · 2016-10-04T18:16:40Z

Alright, pretty sure I got everyone's bash nits. You still can't read it.

k8s-ci-robot · 2016-10-04T18:57:45Z

Jenkins GKE smoke e2e failed for commit 48c1e83. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-github-robot · 2016-10-05T11:02:46Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2016-10-05T11:41:00Z

Automatic merge from submit-queue

deads2k assigned eparis Oct 3, 2016

googlebot added the cla: yes label Oct 3, 2016

k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Oct 3, 2016

eparis reviewed Oct 3, 2016

View reviewed changes

deads2k force-pushed the annoyance-specific-integration-test branch from 08d41ed to a134620 Compare October 4, 2016 12:45

deads2k added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 4, 2016

stevekuznetsov suggested changes Oct 4, 2016

View reviewed changes

specify flags to test-integration

48c1e83

deads2k force-pushed the annoyance-specific-integration-test branch from a134620 to 48c1e83 Compare October 4, 2016 18:16

deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2016

k8s-github-robot merged commit 0ad50d2 into kubernetes:master Oct 5, 2016

deads2k deleted the annoyance-specific-integration-test branch February 1, 2017 17:25

marun mentioned this pull request Feb 15, 2017

Unable to run a specific integration test kubernetes/community#370

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

specify flags to test-integration #33952

specify flags to test-integration #33952

deads2k commented Oct 3, 2016 •

edited by k8s-oncall

k8s-ci-robot commented Oct 3, 2016

eparis commented Oct 3, 2016

k8s-ci-robot commented Oct 3, 2016

eparis Oct 3, 2016 •

edited

eparis Oct 3, 2016

deads2k Oct 3, 2016

deads2k Oct 4, 2016

deads2k commented Oct 4, 2016

stevekuznetsov Oct 4, 2016

stevekuznetsov Oct 4, 2016

deads2k Oct 4, 2016

stevekuznetsov Oct 4, 2016

deads2k Oct 4, 2016

stevekuznetsov Oct 4, 2016

stevekuznetsov Oct 4, 2016 •

edited

deads2k Oct 4, 2016

deads2k commented Oct 4, 2016

k8s-ci-robot commented Oct 4, 2016

k8s-github-robot commented Oct 5, 2016

k8s-github-robot commented Oct 5, 2016

specify flags to test-integration #33952

specify flags to test-integration #33952

Conversation

deads2k commented Oct 3, 2016 • edited by k8s-oncall

k8s-ci-robot commented Oct 3, 2016

eparis commented Oct 3, 2016

k8s-ci-robot commented Oct 3, 2016

eparis Oct 3, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deads2k commented Oct 4, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevekuznetsov Oct 4, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deads2k commented Oct 4, 2016

k8s-ci-robot commented Oct 4, 2016

k8s-github-robot commented Oct 5, 2016

k8s-github-robot commented Oct 5, 2016

deads2k commented Oct 3, 2016 •

edited by k8s-oncall

eparis Oct 3, 2016 •

edited

stevekuznetsov Oct 4, 2016 •

edited