Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for rsync and give friendlier message #34351

Merged
merged 1 commit into from
Oct 8, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions build/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ kube::build::get_docker_wrapped_binaries() {
function kube::build::verify_prereqs() {
kube::log::status "Verifying Prerequisites...."
kube::build::ensure_tar || return 1
kube::build::ensure_rsync || return 1
kube::build::ensure_docker_in_path || return 1
if kube::build::is_osx; then
kube::build::docker_available_on_osx || return 1
Expand Down Expand Up @@ -235,6 +236,13 @@ function kube::build::is_gnu_sed() {
[[ $(sed --version 2>&1) == *GNU* ]]
}

function kube::build::ensure_rsync() {
if [[ -z "$(which rsync)" ]]; then
kube::log::error "Can't find 'rsync' in PATH, please fix and retry."
return 1
fi
}

function kube::build::update_dockerfile() {
if kube::build::is_gnu_sed; then
sed_opts=(-i)
Expand Down